pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Andreas Karlsson <andreas@proxel.se>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Cutting initdb's runtime (Perl question embedded)
Date: Fri, 14 Apr 2017 17:54:19 -0400
Message-ID: <12002.1492206859@sss.pgh.pa.us> (raw)
In-Reply-To: <20170413204223.7znfwllhqmglzaam@alap3.anarazel.de>
References: <30896.1492006367@sss.pgh.pa.us>
	<a15e94ac-c346-5816-69ae-ec6811e32af1@proxel.se>
	<972d541d-7285-53ff-ea71-dcbfd886570a@proxel.se>
	<6312.1492100010@sss.pgh.pa.us>
	<20170413164132.3nhobp4z4wnnvhca@alap3.anarazel.de>
	<27409.1492102574@sss.pgh.pa.us>
	<20170413170614.6pv2mpqiq7s6huio@alap3.anarazel.de>
	<9244.1492106743@sss.pgh.pa.us>
	<20170413204223.7znfwllhqmglzaam@alap3.anarazel.de>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Andres Freund <andres@anarazel.de> writes:
> On 2017-04-13 14:05:43 -0400, Tom Lane wrote:
>> Hm.  That ties into something I was looking at yesterday.  The only
>> reason that function is called so much is that bootstrap mode runs a
>> separate transaction for *each line of the bki file* (cf do_start,
>> do_end in bootparse.y).  Which seems pretty silly.

> Indeed.

I failed to resist the temptation to poke at this, and found that
indeed nothing seems to break if we just use one transaction for the
whole processing of postgres.bki.  So I've pushed a patch that does
that.  We're definitely down to the point where worrying about the
speed of bootstrap mode, per se, is useless; the other steps in
initdb visibly take a lot more time.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (52+ messages)  latest in thread

Message-ID: <12002.1492206859@sss.pgh.pa.us>
Permalink:  ../12002.1492206859@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/12002.1492206859@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, andreas@proxel.se
  Subject: Re: Cutting initdb's runtime (Perl question embedded)
  In-Reply-To: <12002.1492206859@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox