pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Ian Barwick <ian.barwick@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Jonathan S. Katz <jkatz@postgresql.org>
Cc: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: David Rowley <dgrowleyml@gmail.com>
Subject: Re: Improving connection scalability: GetSnapshotData()
Date: Mon, 14 Sep 2020 20:14:48 -0400
Message-ID: <1227660.1600128888@sss.pgh.pa.us> (raw)
In-Reply-To: <20200914231718.gg7v77fx7nvvprjy@alap3.anarazel.de>
References: <1013484.1597609043@sss.pgh.pa.us>
	<20200816203153.xqfvuevinjkweuez@alap3.anarazel.de>
	<20200816205258.pjvmoljrk7ntqb3n@alap3.anarazel.de>
	<20200816211146.nodohy6ck6mzfjwi@alap3.anarazel.de>
	<20200816212657.3vyijoddr2yvgjjc@alap3.anarazel.de>
	<20200903081554.GB8559@paquier.xyz>
	<61291ffe-d611-f889-68b5-c298da9fb18f@2ndquadrant.com>
	<20200908041114.5woxns33iv765fgh@alap3.anarazel.de>
	<0006ffe6-6f76-c074-3e58-2801cee1c05f@2ndquadrant.com>
	<d5f14b0e-58d2-56ab-0938-ab57ecc89d77@2ndquadrant.com>
	<20200914231718.gg7v77fx7nvvprjy@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> I think the approach of having a long running psql session is really
> useful, and probably would speed up some tests. Does anybody have a good
> idea for how to best, and without undue effort, to integrate this into
> PostgresNode.pm?  I don't really have a great idea, so I think I'd leave
> it with a local helper in the new test?

You could use the interactive_psql infrastructure that already exists
for psql/t/010_tab_completion.pl.  That does rely on IO::Pty, but
I think I'd prefer to accept that dependency for such tests over rolling
our own IPC::Run, which is more or less what you've done here.

			regards, tom lane

view thread (102+ messages)  latest in thread

Message-ID: <1227660.1600128888@sss.pgh.pa.us>
Permalink:  ../1227660.1600128888@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1227660.1600128888@sss.pgh.pa.us

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, ian.barwick@2ndquadrant.com, michael@paquier.xyz, robertmhaas@gmail.com, thomas.munro@gmail.com, alvherre@2ndquadrant.com, daniel@yesql.se, jkatz@postgresql.org, a.korotkov@postgrespro.ru, pg@bowt.ie, bruce@momjian.us, dgrowleyml@gmail.com
  Subject: Re: Improving connection scalability: GetSnapshotData()
  In-Reply-To: <1227660.1600128888@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox