From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Cc: David Rowley <dgrowleyml@gmail.com>
Cc: Jaime Soler <jaime.soler@gmail.com>
Subject: Re: pgbench and timestamps (bounced)
Date: Tue, 12 Jan 2021 17:37:56 -0500
Message-ID: <1236015.1610491076@sss.pgh.pa.us> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2011262358470.3117595@pseudo>
References: <alpine.DEB.2.22.394.2006291740420.805678@pseudo>
<1720048.1599525071@sss.pgh.pa.us>
<alpine.DEB.2.22.394.2009111501410.3995562@pseudo>
<6c6af173-85b9-f0b3-4764-b0df415d2736@postgrespro.ru>
<alpine.DEB.2.22.394.2011262358470.3117595@pseudo>
Fabien COELHO <coelho@cri.ensmp.fr> writes:
>> Hi, this entry is "Waiting on Author" and the thread was inactive for a
>> while. I see this discussion still has some open questions. Are you
>> going to continue working on it, or should I mark it as "returned with
>> feedback" until a better time?
> IMHO the proposed fix is reasonable and addresses the issue.
> I have responded to Tom's remarks about it, and it is waiting for his
> answer to my counter arguments. So ISTM that the patch is currently still
> waiting for some feedback.
It looks like my unhappiness with injecting a pthread dependency into
pgbench is going to be overtaken by events in the "option delaying
queries" thread [1]. However, by the same token there are some conflicts
between the two patchsets, and also I prefer the other thread's approach
to portability (i.e. do it honestly, not with a private portability layer
in pgbench.c). So I'm inclined to put the parts of this patch that
require pthreads on hold till that lands.
What remains that we could do now, and perhaps back-patch, is point (2)
i.e. disallow digits as the first character of a pgbench variable name.
That would be enough to "solve" the original bug report, and it does seem
like it could be back-patched, while we're certainly not going to risk
back-patching anything as portability-fraught as introducing mutexes.
regards, tom lane
[1] https://www.postgresql.org/message-id/flat/20200227180100.zyvjwzcpiokfsqm2%40alap3.anarazel.de
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, coelho@cri.ensmp.fr, a.lubennikova@postgrespro.ru, pgsql-hackers@lists.postgresql.org, dgrowleyml@gmail.com, jaime.soler@gmail.com
Subject: Re: pgbench and timestamps (bounced)
In-Reply-To: <1236015.1610491076@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox