From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Gripes about walsender command processing
Date: Mon, 14 Sep 2020 23:34:44 -0400
Message-ID: <1236185.1600140884@sss.pgh.pa.us> (raw)
In-Reply-To: <20200915032215.GM2183@paquier.xyz>
References: <880181.1600026471@sss.pgh.pa.us>
<20200914080454.GE2183@paquier.xyz>
<1122166.1600102299@sss.pgh.pa.us>
<20200915032215.GM2183@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> On Mon, Sep 14, 2020 at 12:51:39PM -0400, Tom Lane wrote:
>> (Is there a better way to get the name of a replication command?
>> I didn't look very hard for one.)
> Wouldn't that just be in cmdtaglist.h, but extended for nodes used for
> replication commands? Then you could just call CreateCommandTag() to
> get the command string to print as postgres.c does. There is already
> one for repslot drop, in some way. This would have the advantage to
> just call once set_ps_display() before the switch split.
Mmm, not sure whether having CreateCommandTag know about replication
commands is a good thing or not. We certainly could do it like that,
since there's only one namespace of NodeTag values, but conceptually
it feels a bit weird to me. There's a lot of other infrastructure
for SQL command nodes that we're surely never going to build out for
replication commands, so should we do it in CreateCommandTag?
Anybody else have an opinion about it?
(I don't quite follow your comment about repslot drop, btw.)
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org
Subject: Re: Gripes about walsender command processing
In-Reply-To: <1236185.1600140884@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox