From: Zdenek Kotala <Zdenek.Kotala@Sun.COM>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Compiler warning cleanup - unitilized const variables, pointer type mismatch
Date: Fri, 29 May 2009 14:36:41 +0200
Message-ID: <1243600601.1301.18.camel@localhost> (raw)
In-Reply-To: <10558.1243525323@sss.pgh.pa.us>
References: <1243501880.1372.23.camel@localhost>
<10558.1243525323@sss.pgh.pa.us>
Tom Lane píše v čt 28. 05. 2009 v 11:42 -0400:
> Zdenek Kotala <Zdenek.Kotala@Sun.COM> writes:
> > I attached another cleanup patch which fixes following warnings reported
> > by Sun Studio:
>
> I'm not too impressed with any of these. The proposed added
> initializers just increase future maintenance effort without solving
> any real problem (since the variables are required by C standard to
> initialize to zero).
Agree.
> The proposed signature change on psql_completion
> is going to replace a warning on your system with outright failures on
> other people's.
I check readline and definition is still same at least from 5.0 version.
I'm not still understand why it should failure on other systems. I
looked on revision 1.30 of the file and there is only readline-4.2
support mentioned. Is readline 4.2 the problem?
Zdenek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: Zdenek.Kotala@Sun.COM, tgl@sss.pgh.pa.us
Subject: Re: Compiler warning cleanup - unitilized const variables, pointer type mismatch
In-Reply-To: <1243600601.1301.18.camel@localhost>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox