From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <david.rowley@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Reducing the runtime of the core regression tests
Date: Thu, 11 Apr 2019 00:44:02 -0400
Message-ID: <12465.1554957842@sss.pgh.pa.us> (raw)
In-Reply-To: <CAKJS1f-q20sS1zVaDvWP3CKvAHse=1+pbE_aOaBiRizJPNgUZA@mail.gmail.com>
References: <735.1554935715@sss.pgh.pa.us>
<CAKJS1f-q20sS1zVaDvWP3CKvAHse=1+pbE_aOaBiRizJPNgUZA@mail.gmail.com>
David Rowley <david.rowley@2ndquadrant.com> writes:
> I was surprised to see nothing mentioned about attempting to roughly
> sort the test order in each parallel group according to their runtime.
I'm confused about what you have in mind here? I'm pretty sure pg_regress
launches all the scripts in a group at the same time, so that just
rearranging the order they're listed in on the schedule line shouldn't
make any noticeable difference. If you meant changing the order of
operations within each script, I don't really want to go there.
It'd require careful per-script analysis, and to the extent that the
existing tests have some meaningful ordering (admittedly, many don't),
we'd lose that.
>> Thoughts? Anyone object to making these sorts of changes
>> post-feature-freeze?
> I think it's a good time to do this sort of thing. It should be
> easier to differentiate tests destabilising due to this change out
> from the noise of other changes that are going in.... since currently,
> the rate of those other changes should not be very high. Doing it any
> later in the freeze does not seem better since we might discover some
> things that need to be fixed due to this.
Yeah. I wouldn't propose pushing this in shortly before beta, but
if we do it now then we've probably got a month to sort out any
problems that may appear.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, david.rowley@2ndquadrant.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Reducing the runtime of the core regression tests
In-Reply-To: <12465.1554957842@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox