From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgindent vs dtrace on macos
Date: Tue, 22 Sep 2020 11:35:55 -0400
Message-ID: <1246519.1600788955@sss.pgh.pa.us> (raw)
In-Reply-To: <1177223.1600784320@sss.pgh.pa.us>
References: <20200917000334.GA28142@alvherre.pgsql>
<66137.1600303192@sss.pgh.pa.us>
<1019914.1600714537@sss.pgh.pa.us>
<B498B70E-C1D7-474B-871B-8B2C35F840FB@yesql.se>
<1177223.1600784320@sss.pgh.pa.us>
After further thought about this, I concluded that a much better idea
is to just exclude fmgrprotos.h from the pgindent run. While renaming
these two functions may or may not be worthwhile, it doesn't provide
any sort of permanent fix for fmgrprotos.h, because new typedef conflicts
could arise at any time. (The fact that the typedef list isn't fully
under our control, thanks to contributions from system headers, makes
this a bigger risk than it might appear.)
So I did that, and also added a README comment along the lines you
suggested.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, daniel@yesql.se, alvherre@2ndquadrant.com, peter.eisentraut@2ndquadrant.com
Subject: Re: pgindent vs dtrace on macos
In-Reply-To: <1246519.1600788955@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox