pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Simon Riggs <simon@2ndQuadrant.com>
To: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Hot Standby on git
Date: Thu, 01 Oct 2009 15:45:30 +0100
Message-ID: <1254408330.17864.233.camel@ebony.2ndQuadrant> (raw)
In-Reply-To: <4AC2FBB9.7060304@enterprisedb.com>
References: <1253958559.4449.833.camel@ebony.2ndQuadrant>
	<4AC2FBB9.7060304@enterprisedb.com>


On Wed, 2009-09-30 at 09:33 +0300, Heikki Linnakangas wrote:

> Looking at the changes to StartupMultiXact, you're changing the locking
> so that both MultiXactOffsetControlLock and MultiXactMemberControlLock
> are acquire first before changing anything. Why? Looking at the other
> functions in that file, all others that access both files are happy to
> acquire one lock at a time, like StartupMultiXact does without the patch.

I think those changes are just paranoia from early versions of patch.

We now know for certain that MultiXact isn't used at the time
StartupMultiXact() is called. The same isn't true for StartupClog() and
StartupSubtrans() which need to cope with concurrent callers.

Will remove changes and document that nothing touching it when it runs.

-- 
 Simon Riggs           www.2ndQuadrant.com

view thread (48+ messages)  latest in thread

Message-ID: <1254408330.17864.233.camel@ebony.2ndQuadrant>
Permalink:  ../1254408330.17864.233.camel@ebony.2ndQuadrant/
Also on:    postgresql.org/message-id/1254408330.17864.233.camel@ebony.2ndQuadrant

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: simon@2ndQuadrant.com, heikki.linnakangas@enterprisedb.com
  Subject: Re: Hot Standby on git
  In-Reply-To: <1254408330.17864.233.camel@ebony.2ndQuadrant>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox