pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andreas Karlsson <andreas@proxel.se>
To: Stephen Frost <sfrost@snowman.net>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: Michael Banck <michael.banck@credativ.de>
Cc: Peter Geoghegan <pg@heroku.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Reload SSL certificates on SIGHUP
Date: Wed, 4 Jan 2017 16:17:49 +0100
Message-ID: <1254e97b-a65a-5a63-e938-810507a16d71@proxel.se> (raw)
In-Reply-To: <20170104151429.GP18360@tamriel.snowman.net>
References: <05677cd3-63b2-b15b-7afd-798e34e607c7@proxel.se>
	<CAB7nPqQU50-UMuFcffmynDbH7_kBx3N-Q3ujL-nM2OF3X8biMA@mail.gmail.com>
	<16e282a4-2573-f629-09e8-e6b0ac615890@2ndquadrant.com>
	<29982.1483412575@sss.pgh.pa.us>
	<CABUevExczKi876tfqH5dY7QcMQu6v3KFBwckozD_OJr0kgVidw@mail.gmail.com>
	<23913.1483458895@sss.pgh.pa.us>
	<CABUevEzWtbL8PqcYXEagCVH_NHYQdMcXqZv4GXEeCW=kkd-J0Q@mail.gmail.com>
	<20995.1483541230@sss.pgh.pa.us>
	<CABUevExdkO3TTLYhc2oQAOWXbnz+mJ8=Tfg+WsB2P6p-_wfYyg@mail.gmail.com>
	<7fca80da-0274-3f36-eb25-d53f940c1977@proxel.se>
	<20170104151429.GP18360@tamriel.snowman.net>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

On 01/04/2017 04:14 PM, Stephen Frost wrote:
> * Andreas Karlsson (andreas@proxel.se) wrote:
>> A possible solution might be to only add the error throwing hook
>> when loading certificates during SIGHUP (and at Windows) and to work
>> as before on startup. Would that be an acceptable solution? I could
>> write a patch for this if people are interested.
>
> I'm not sure I see how that's a solution..?  Wouldn't that mean that a
> SIGHUP with an encrypted key would result in a failure?
>
> The solution, at least in my view, seems to be to say "sorry, we can't
> reload the SSL stuff if you used a passphrase to unlock the key on
> startup, you will have to perform a restart if you want the SSL bits to
> be changed."

Sorry, I was very unclear. I meant refusing the reload the SSL context 
if there is a pass phrase, but that the rest of the config will be 
reloaded just fine. This will lead to some log spam on every SIGHUP for 
people with a pass phrase but should otherwise work as before.

Andreas


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (69+ messages)  latest in thread

Message-ID: <1254e97b-a65a-5a63-e938-810507a16d71@proxel.se>
Permalink:  ../1254e97b-a65a-5a63-e938-810507a16d71@proxel.se/
Also on:    postgresql.org/message-id/1254e97b-a65a-5a63-e938-810507a16d71@proxel.se

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: andreas@proxel.se, sfrost@snowman.net, magnus@hagander.net, tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, michael.paquier@gmail.com, michael.banck@credativ.de, pg@heroku.com
  Subject: Re: [PATCH] Reload SSL certificates on SIGHUP
  In-Reply-To: <1254e97b-a65a-5a63-e938-810507a16d71@proxel.se>
  References: <05677cd3-63b2-b15b-7afd-798e34e607c7@proxel.se> <CAB7nPqQU50-UMuFcffmynDbH7_kBx3N-Q3ujL-nM2OF3X8biMA@mail.gmail.com> <16e282a4-2573-f629-09e8-e6b0ac615890@2ndquadrant.com> <29982.1483412575@sss.pgh.pa.us> <CABUevExczKi876tfqH5dY7QcMQu6v3KFBwckozD_OJr0kgVidw@mail.gmail.com> <23913.1483458895@sss.pgh.pa.us> <CABUevEzWtbL8PqcYXEagCVH_NHYQdMcXqZv4GXEeCW=kkd-J0Q@mail.gmail.com> <20995.1483541230@sss.pgh.pa.us> <CABUevExdkO3TTLYhc2oQAOWXbnz+mJ8=Tfg+WsB2P6p-_wfYyg@mail.gmail.com> <7fca80da-0274-3f36-eb25-d53f940c1977@proxel.se> <20170104151429.GP18360@tamriel.snowman.net> <1254e97b-a65a-5a63-e938-810507a16d71@proxel.se>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox