pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Simon Riggs <simon@2ndQuadrant.com>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Small Bug in GetConflictingVirtualXIDs
Date: Mon, 21 Dec 2009 07:46:39 +0000
Message-ID: <1261381599.17644.1803.camel@ebony> (raw)
In-Reply-To: <200912210402.37850.andres@anarazel.de>
References: <200912210402.37850.andres@anarazel.de>

On Mon, 2009-12-21 at 04:02 +0100, Andres Freund wrote:

> The logic behind this seems fine except in the case of dropping a database. 
> There you very well might have a open connection without an open snapshot.

Yes, you're right, thanks for the report. 

I re-arranged the logic there recently to reduce the number of backends
that would conflict, so it looks like I broke that case when I did
that. 

> Should easily be solvable through an extra parameter for 
> GetConflictingVirtualXIDs. Want me to prepare a patch?

Much appreciated, thanks.

-- 
 Simon Riggs           www.2ndQuadrant.com




view thread (14+ messages)  latest in thread

Message-ID: <1261381599.17644.1803.camel@ebony>
Permalink:  ../1261381599.17644.1803.camel@ebony/
Also on:    postgresql.org/message-id/1261381599.17644.1803.camel@ebony

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: simon@2ndQuadrant.com, andres@anarazel.de
  Subject: Re: Small Bug in GetConflictingVirtualXIDs
  In-Reply-To: <1261381599.17644.1803.camel@ebony>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox