pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH 1/1] Fix compilation on mac with Xcode >= 11.4.
Date: Thu, 19 Nov 2020 21:48:52 -0500
Message-ID: <1261863.1605840532@sss.pgh.pa.us> (raw)
In-Reply-To: <1260724.1605838811@sss.pgh.pa.us>
References: <20201120003314.20560-1-james.hilliard1@gmail.com>
	<1256728.1605832823@sss.pgh.pa.us>
	<CADvTj4pTDEvpK3s5be6RZHs7yeRmpoCMjWKaZdjCFCce_K+1eQ@mail.gmail.com>
	<1257704.1605834289@sss.pgh.pa.us>
	<CADvTj4rUUeonoofadhhBo9b9TV3DDqQEg9n1NOfWP4V80PqK4Q@mail.gmail.com>
	<1260724.1605838811@sss.pgh.pa.us>

I wrote:
> However ... it then occurred to me to blow away my ccache and accache,
> and after rebuilding from scratch, everything's fine.  So, are you
> using ccache?

Oh, scratch that, I fat-fingered the experiment somehow.  The issue
is still there.  Still, I'm hesitant to apply the fix you suggest,
because of the law of unintended consequences.  In particular, I'm
afraid that using -isysroot in the link step might result in executables
that are bound to that sysroot and will not work if it's not there
--- thus causing a problem for packagers trying to distribute PG
to non-developers.

We had a great deal of trouble in the initial experiments with
-isysroot, cf

https://www.postgresql.org/message-id/flat/20840.1537850987%40sss.pgh.pa.us

so I'm not that eager to mess with it.  I'm inclined to think that
this is more a case of "Apple broke ABI and they ought to fix that".

			regards, tom lane





view thread (13+ messages)  latest in thread

Message-ID: <1261863.1605840532@sss.pgh.pa.us>
Permalink:  ../1261863.1605840532@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1261863.1605840532@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, james.hilliard1@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: [PATCH 1/1] Fix compilation on mac with Xcode >= 11.4.
  In-Reply-To: <1261863.1605840532@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox