pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: tanghy.fnst@fujitsu.com
Cc: smithpb2250@gmail.com
Cc: peter.eisentraut@enterprisedb.com
Cc: david.zhang@highgo.ca
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Support tab completion for upper character inputs in psql
Date: Thu, 22 Apr 2021 23:17:19 -0400
Message-ID: <1280270.1619147839@sss.pgh.pa.us> (raw)
In-Reply-To: <20210423.115812.900808736988307020.horikyota.ntt@gmail.com>
References: <OS0PR01MB611303B647967B6949B759F1FB4E9@OS0PR01MB6113.jpnprd01.prod.outlook.com>
	<CAHut+Pu+Jcpjrry8t29J99+v09Ou0MSLZCqghUAoeyfCnOpznA@mail.gmail.com>
	<OS0PR01MB61131A4347D385F02F60E123FB469@OS0PR01MB6113.jpnprd01.prod.outlook.com>
	<20210423.115812.900808736988307020.horikyota.ntt@gmail.com>

Kyotaro Horiguchi <horikyota.ntt@gmail.com> writes:
> All usages of pg_string_tolower don't need a copy.
> So don't we change the function to in-place converter?

Doesn't seem like a good idea, because that locks us into an assumption
that the downcasing conversion doesn't change the string's physical
length.  There are a lot of counterexamples to that :-(.  I'm not sure
that we actually implement such cases correctly today, but let's not
build APIs that prevent it from being fixed.

			regards, tom lane

view thread (54+ messages)  latest in thread

Message-ID: <1280270.1619147839@sss.pgh.pa.us>
Permalink:  ../1280270.1619147839@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1280270.1619147839@sss.pgh.pa.us

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, horikyota.ntt@gmail.com, tanghy.fnst@fujitsu.com, smithpb2250@gmail.com, peter.eisentraut@enterprisedb.com, david.zhang@highgo.ca, pgsql-hackers@lists.postgresql.org
  Subject: Re: Support tab completion for upper character inputs in psql
  In-Reply-To: <1280270.1619147839@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox