From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: pgsql-hackers@postgresql.org, Andres Freund <andres@anarazel.de>
Subject: Re: Should contrib modules install .h files?
Date: Tue, 3 Jul 2018 09:29:55 +0200
Message-ID: <12ba9c72-504f-b911-f0ce-1dff2826fa5b@2ndquadrant.com> (raw)
In-Reply-To: <63444.1530537990@sss.pgh.pa.us>
References: <87y3euomjh.fsf@news-spur.riddles.org.uk>
<ee05ea4c-3d5b-0ec6-8daa-3ec66f021076@2ndquadrant.com>
<87tvpinfr4.fsf@news-spur.riddles.org.uk>
<63444.1530537990@sss.pgh.pa.us>
On 02.07.18 15:26, Tom Lane wrote:
> FWIW, I agree with Andres' thought that each contrib module should have
> its own subdirectory under $(includedir_server). Otherwise we're going
> to be faced with questions about whether .h files need to be renamed
> because they're not globally unique enough.
Then they perhaps should be renamed. That seems like a much simpler
solution.
The use case being discussed here is installing a data type extension's
header so you can write a transform for it. The extension's name as
well as the data type's own name already have to be pretty much globally
unique if you want it to be useful. So it doesn't seem very difficult
to me to have the extension install a single header file with that same
name.
The other side of this is that the PLs have to install their header
files. Which the in-core PLs already do. Would we we want to move
their header files under a new per-extension directory scheme?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, tgl@sss.pgh.pa.us, andrew@tao11.riddles.org.uk, andres@anarazel.de
Subject: Re: Should contrib modules install .h files?
In-Reply-To: <12ba9c72-504f-b911-f0ce-1dff2826fa5b@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox