From: Jonathan S. Katz <jkatz@postgresql.org>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: houzj.fnst@fujitsu.com <houzj.fnst@fujitsu.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: why can't a table be part of the same publication as its schema
Date: Mon, 19 Sep 2022 16:52:06 -0400
Message-ID: <12f66d81-8675-dbf4-a770-4094d478551a@postgresql.org> (raw)
In-Reply-To: <20220919151627.ah6dhz7me4uiooz3@alvherre.pgsql>
References: <20220919151627.ah6dhz7me4uiooz3@alvherre.pgsql>
On 9/19/22 11:16 AM, Alvaro Herrera wrote:
>
>> diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml
>> index 1ae3287..0ab768d 100644
>> --- a/doc/src/sgml/logical-replication.sgml
>> +++ b/doc/src/sgml/logical-replication.sgml
>> @@ -1120,6 +1120,11 @@ test_sub=# SELECT * FROM child ORDER BY a;
>> </para>
>>
>> <para>
>> + Specifying a column list when the publication also publishes
>> + <literal>FOR ALL TABLES IN SCHEMA</literal> is not supported.
>> + </para>
>> +
>> + <para>
>> For partitioned tables, the publication parameter
>> <literal>publish_via_partition_root</literal> determines which column list
>> is used. If <literal>publish_via_partition_root</literal> is
>>
>> diff --git a/doc/src/sgml/ref/create_publication.sgml b/doc/src/sgml/ref/create_publication.sgml
>> index 0a68c4b..0ced7da 100644
>> --- a/doc/src/sgml/ref/create_publication.sgml
>> +++ b/doc/src/sgml/ref/create_publication.sgml
>> @@ -103,17 +103,17 @@ CREATE PUBLICATION <replaceable class="parameter">name</replaceable>
>> </para>
>>
>> <para>
>> + Specifying a column list when the publication also publishes
>> + <literal>FOR ALL TABLES IN SCHEMA</literal> is not supported.
>> + </para>
>>
>> @@ -733,6 +694,24 @@ CheckPubRelationColumnList(List *tables, const char *queryString,
>> continue;
>>
>> /*
>> + * Disallow specifying column list if any schema is in the
>> + * publication.
>> + *
>> + * XXX We could instead just forbid the case when the publication
>> + * tries to publish the table with a column list and a schema for that
>> + * table. However, if we do that then we need a restriction during
>> + * ALTER TABLE ... SET SCHEMA to prevent such a case which doesn't
>> + * seem to be a good idea.
>> + */
>> + if (publish_schema)
>> + ereport(ERROR,
>> + errcode(ERRCODE_INVALID_PARAMETER_VALUE),
>> + errmsg("cannot use publication column list for relation \"%s.%s\"",
>> + get_namespace_name(RelationGetNamespace(pri->relation)),
>> + RelationGetRelationName(pri->relation)),
>> + errdetail("Column list cannot be specified if any schema is part of the publication or specified in the list."));
>> +
>
> This seems a pretty arbitrary restriction. It feels like you're adding
> this restriction precisely so that you don't have to write the code to
> reject the ALTER .. SET SCHEMA if an incompatible configuration is
> detected. But we already have such checks in several cases, so I don't
> see why this one does not seem a good idea.
>
> The whole FOR ALL TABLES IN SCHEMA thing seems pretty weird in several
> aspects. Others have already commented about the syntax, which is
> unlike what GRANT uses; I'm also surprised that we've gotten away with
> it being superuser-only. Why are we building more superuser-only
> features in this day and age? I think not even FOR ALL TABLES should
> require superuser.
FYI, I've added this to the PG15 open items as there are some open
questions to resolve in this thread.
Jonathan
Attachments:
OpenPGP_signature (application/pgp-signature, 839B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: jkatz@postgresql.org, alvherre@alvh.no-ip.org, houzj.fnst@fujitsu.com, amit.kapila16@gmail.com, vignesh21@gmail.com, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, peter.eisentraut@enterprisedb.com
Subject: Re: why can't a table be part of the same publication as its schema
In-Reply-To: <12f66d81-8675-dbf4-a770-4094d478551a@postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox