public inbox for [email protected]
help / color / mirror / Atom feedFrom: Peter Eisentraut <[email protected]>
To: Pavel Borisov <[email protected]>
Cc: Peter Geoghegan <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: UNIQUE null treatment option
Date: Thu, 3 Feb 2022 11:54:10 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CALT9ZEHV1uQZzLY=adSF5Bhfj3DaSLCZRmUJCSF=5F0EjV5cUw@mail.gmail.com>
References: <[email protected]>
<[email protected]>
<CAH2-Wz=K67yJSuF-VF+FHA7MhGdht2WohFyTmSJeFD0C9bOtSQ@mail.gmail.com>
<[email protected]>
<CALT9ZEHV1uQZzLY=adSF5Bhfj3DaSLCZRmUJCSF=5F0EjV5cUw@mail.gmail.com>
On 28.01.22 13:56, Pavel Borisov wrote:
> Makes sense. Here is an updated patch with this change.
>
> I didn't end up renaming anynullkeys. I came up with names like
> "anyalwaysdistinctkeys", but in the end that felt too abstract, and
> moreover, it would require rewriting a bunch of code comments that
> refer
> to null values in this context. Since as you wrote, anynullkeys is
> just
> a local concern between two functions, this slight inaccuracy is
> perhaps
> better than some highly general but unclear terminology.
>
> Agree with that. With the comment it is clear how it works.
>
> I've looked at the patch v3. It seems good enough for me. CFbot tests
> have also come green.
> Suggest it is RFC now.
Committed. Thanks.
view thread (3+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: UNIQUE null treatment option
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox