From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org, Andres Freund <andres@anarazel.de>
Subject: Re: Splitting up guc.c
Date: Sun, 11 Sep 2022 18:31:41 -0400
Message-ID: <1305798.1662935501@sss.pgh.pa.us> (raw)
In-Reply-To: <925946.1662918775@sss.pgh.pa.us>
References: <587607.1662836699@sss.pgh.pa.us>
<Yx0vHEBXwcUggZYK@paquier.xyz>
<666417.1662862120@sss.pgh.pa.us>
<925946.1662918775@sss.pgh.pa.us>
Here's a v3 that gets rid of guc_hooks.c in favor of moving the
hook functions to related modules (though some did end up in
variables.c for lack of a better idea). I also pushed all the
hook function declarations to guc_hooks.h. Unsurprisingly,
removal of guc.h #includes from header files led to discovery
of some surprising indirect dependencies, notably a lot of places
were evidently depending on indirect inclusions of array.h.
I think this is code-complete at this point. I'd like to not
sit on it too long, because it'll inevitably get side-swiped
by additions of new GUCs. On the other hand, pushing it in
the middle of a CF would presumably break other people's patches.
Maybe push it at the end of this CF, to give people a month to
rebase anything that's affected?
regards, tom lane
Attachments:
split-up-guc-code-3.patch.gz (application/x-gzip, 92.2K) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, andres@anarazel.de
Subject: Re: Splitting up guc.c
In-Reply-To: <1305798.1662935501@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox