public inbox for [email protected]
help / color / mirror / Atom feedFrom: David Geier <[email protected]>
To: Peter Eisentraut <[email protected]>
To: Chao Li <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: get rid of Pointer type, mostly
Date: Tue, 3 Feb 2026 12:09:58 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
<CA+Tgmobo9ZMC0h1Z1Te9whf7q3LN7wUkzFLyuxfMZ4dyTNqKnw@mail.gmail.com>
<[email protected]>
<CA+TgmobhKe5WJybZ0EGQ85Qkxr-KLx4uW2_hFqt0iPbYq-af7Q@mail.gmail.com>
<[email protected]>
<CA+Tgmob==vi7MXZC9EhTGZ2YiuWkQuAGZm=H6M=9zPN2tp4s3A@mail.gmail.com>
<[email protected]>
<CA+TgmobFfk2y9jXPzzme-3qQCJC9LFnd2G9RBMCE9haVJkCQ+w@mail.gmail.com>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
Hi Peter,
>> Either way is fine by me. It just seemed like the majority of commenters
>> where in favor of keeping some type in the GIN code for readability.
>
> After further consideration, I think it is best to leave this alone as
> is. One particular problem is that Pointer is part of the documented
> API of GIN, and if we either remove it or rename it, then this would
> create a bunch of work for extensions to keep their code compiling
> across major versions.
That's a pity. It would have been a nice cleanup of some crufty code
that makes readability harder than needed. Seems like a simple rename
would be acceptable in the spirit of e.g. [1].
--
David Geier
[1]
https://www.postgresql.org/message-id/2273bc2a-045d-4a75-8584-7cd9396e5534%40eisentraut.org
view thread (4+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: get rid of Pointer type, mostly
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox