From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: Re: PANIC: invalid index offnum: 186 when processing BRIN indexes in VACUUM
Date: Tue, 31 Oct 2017 15:46:32 -0400
Message-ID: <13135.1509479192@sss.pgh.pa.us> (raw)
In-Reply-To: <11499.1509476951@sss.pgh.pa.us>
References: <20171031181053.xh7hzminpv6rvwr2@alvherre.pgsql>
<11499.1509476951@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
I wrote:
> maybe
> we just have some run-of-the-mill bugs to find, like the off-the-end
> bug I spotted in brin_doupdate. There's apparently at least one
> more, but given the error message it must be something like not
> checking for a page to have turned into a revmap page. Shouldn't
> be too hard to find...
Actually, I think it might be as simple as the attached.
brin_getinsertbuffer checks for the old page having turned into revmap,
but the "samepage" path in brin_doupdate does not :-(
With this applied, Alvaro's version of the test case has survived
without error for quite a bit longer than its former MTBF. There
might still be some issues though in other code paths.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackersAttachments:
[text/x-diff] fix-brin_doupdate.patch (1.1K, ../13135.1509479192@sss.pgh.pa.us/2-fix-brin_doupdate.patch)
download | inline diff:diff --git a/src/backend/access/brin/brin_pageops.c b/src/backend/access/brin/brin_pageops.cindex 80f803e..b0f86f3 100644
*** a/src/backend/access/brin/brin_pageops.c
--- b/src/backend/access/brin/brin_pageops.c
*************** brin_doupdate(Relation idxrel, BlockNumb
*** 113,121 ****
/*
* Check that the old tuple wasn't updated concurrently: it might have
! * moved someplace else entirely ...
*/
! if (!ItemIdIsNormal(oldlp))
{
LockBuffer(oldbuf, BUFFER_LOCK_UNLOCK);
--- 113,127 ----
/*
* Check that the old tuple wasn't updated concurrently: it might have
! * moved someplace else entirely, and for that matter the whole page
! * might've become a revmap page. Note that in the first two cases
! * checked here, the "oldlp" we just calculated is garbage; but
! * PageGetItemId() is simple enough that it was safe to do that
! * calculation anyway.
*/
! if (!BRIN_IS_REGULAR_PAGE(oldpage) ||
! oldoff > PageGetMaxOffsetNumber(oldpage) ||
! !ItemIdIsNormal(oldlp))
{
LockBuffer(oldbuf, BUFFER_LOCK_UNLOCK);
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, michael.paquier@gmail.com, tomas.vondra@2ndquadrant.com
Subject: Re: Re: PANIC: invalid index offnum: 186 when processing BRIN indexes in VACUUM
In-Reply-To: <13135.1509479192@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox