From: Peter Eisentraut <peter_e@gmx.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: -Wcast-qual cleanup, part 1
Date: Thu, 10 Nov 2011 21:57:43 +0200
Message-ID: <1320955063.20692.2.camel@vanquo.pezone.net> (raw)
In-Reply-To: <24642.1320678470@sss.pgh.pa.us>
References: <1320642785.25734.13.camel@vanquo.pezone.net>
<CA+TgmoaBFM4ok9G1Ro16Lto16oYSe=_8tXTQxuO4fkCN6U+6Yg@mail.gmail.com>
<24642.1320678470@sss.pgh.pa.us>
On mån, 2011-11-07 at 10:07 -0500, Tom Lane wrote:
> >> 2. Macros accessing structures should come in two variants: a
> "get"
> >> version, and a "set"/anything else version, so that the "get"
> version
> >> can preserve the const qualifier.
>
> I'm not prepared to buy into that as a general coding rule.
>
> Maybe it would be better to just add -Wno-cast-qual to CFLAGS.
OK, I understand the concerns that have been raised here and in the
other thread. I'll work instead on removing "lying" const qualifiers on
the upper layers that were the causes of attempting to push the consts
down.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter_e@gmx.net, tgl@sss.pgh.pa.us, robertmhaas@gmail.com
Subject: Re: -Wcast-qual cleanup, part 1
In-Reply-To: <1320955063.20692.2.camel@vanquo.pezone.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox