pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: Tomas Vondra <tomas@vondra.me>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Japin Li <japinli@hotmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Cannot find a working 64-bit integer type on Illumos
Date: Tue, 25 Mar 2025 19:36:34 -0400
Message-ID: <1338393.1742945794@sss.pgh.pa.us> (raw)
In-Reply-To: <9E6BD828-B535-45F5-B7E1-909473CDDD8B@yesql.se>
References: <2397643.1733347237@sss.pgh.pa.us>
	<CA+hUKGLf9CKuAgwKZ4ZBDWvqkSe729D+rXZ-vMpU37-BLso9TQ@mail.gmail.com>
	<2401111.1733349005@sss.pgh.pa.us>
	<2402151.1733349346@sss.pgh.pa.us>
	<CA+hUKG+AyuDcY5BX8uut2id11UDm-V+uwHz--o3h_iF1UKBhZA@mail.gmail.com>
	<CA+hUKGJj71+xFnEF8D26MMYiATNSECdi=3tcpm1kncpmLDJd7w@mail.gmail.com>
	<2412342.1733354191@sss.pgh.pa.us>
	<CA+hUKGKn_EkNNGMY5RzMcKP+a6urT4JF=CPhw_zHtQwjvX6P2g@mail.gmail.com>
	<a6fe6b44-e5f7-4edd-a451-bff69170dadd@eisentraut.org>
	<CA+hUKGKs-QSkM-AnmU55aSrxxrYEDA9A4YoNaE4t4ma-3CAFYQ@mail.gmail.com>
	<Z-MhRzoc7t-nPUQG@nathan>
	<CA+hUKG+iDwkHX4DkXYZ6LO0LWA4DCfexuP3zBFfeTJq4_FhJwQ@mail.gmail.com>
	<1321975.1742943697@sss.pgh.pa.us>
	<9E6BD828-B535-45F5-B7E1-909473CDDD8B@yesql.se>

Daniel Gustafsson <daniel@yesql.se> writes:
>> On 26 Mar 2025, at 00:01, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> How did that work before?  Perhaps somebody just now added a libpq
>> dependency to pg_regress.c?

> I believe the libpq dependency came in 66d6086cbcbfc8 which wasn't all that
> recent.

It looks like this has been broken for a very long time, but it must
never have mattered before because libpq-fe.h is so stable, and
pg_regress doesn't use any new-ish APIs from it.  So pulling in
whatever version the platform had still worked.

I think this should work to fix it:

-pg_regress.o: override CPPFLAGS += -I$(top_builddir)/src/port -I$(libpq_srcdir) $(EXTRADEFS)
+pg_regress.o: override CPPFLAGS := -I$(top_builddir)/src/port -I$(libpq_srcdir) $(EXTRADEFS) $(CPPFLAGS)

but I haven't tested yet.

			regards, tom lane





view thread (78+ messages)  latest in thread

Message-ID: <1338393.1742945794@sss.pgh.pa.us>
Permalink:  ../1338393.1742945794@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1338393.1742945794@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, daniel@yesql.se, thomas.munro@gmail.com, nathandbossart@gmail.com, peter@eisentraut.org, tomas@vondra.me, hlinnaka@iki.fi, japinli@hotmail.com, andres@anarazel.de, pgsql-hackers@lists.postgresql.org
  Subject: Re: Cannot find a working 64-bit integer type on Illumos
  In-Reply-To: <1338393.1742945794@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox