From: Alvaro Herrera <alvherre@commandprompt.com>
To: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Fujii Masao <masao.fujii@gmail.com>
Cc: Andres Freund <andres@2ndquadrant.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: WAL format changes
Date: Mon, 25 Jun 2012 20:42:43 -0400
Message-ID: <1340671279-sup-3382@alvh.no-ip.org> (raw)
In-Reply-To: <4FE8FDBE.8060901@enterprisedb.com>
References: <4FDA5136.6080206@enterprisedb.com>
<201206142358.12431.andres@2ndquadrant.com>
<CA+TgmobG9VWWvLXeK0XOxoWXtza8JTFgSu2eoAtVFucxH6gLBw@mail.gmail.com>
<4FDF6E8E.4080900@enterprisedb.com>
<4FE034D0.5070900@enterprisedb.com>
<CA+TgmoZu=UMKLJDQ5FNRqPnomiGOSdEvzaj_Gg9CJzcPnvuxgQ@mail.gmail.com>
<4FE73F3F.5040105@enterprisedb.com>
<CAHGQGwHpdpPrmbq49yOp=zZTsiB+_cnwojRh0Xe9BE1D8fLegg@mail.gmail.com>
<CAHGQGwGZo-hv2Fxm3LpCsh=mh1T_21mj7MKe35VQyBSZ6PsyVw@mail.gmail.com>
<CA+TgmoZz=7xRhg389Qj=SwdVCvpK4VSpjJm_yg7WKQuUpk0wjw@mail.gmail.com>
<4FE8FDBE.8060901@enterprisedb.com>
Excerpts from Heikki Linnakangas's message of lun jun 25 20:09:34 -0400 2012:
> On 25.06.2012 21:01, Robert Haas wrote:
> > On Mon, Jun 25, 2012 at 1:57 PM, Fujii Masao<masao.fujii@gmail.com> wrote:
> >>> "<<" should be">>". The attached patch fixes this typo.
> >>
> >> Oh, I forgot to attach the patch.. Here is the patch.
> >
> > I committed both of the patches you posted to this thread.
>
> Thanks Robert. I was thinking that "pg_resetxlog -l" would accept a WAL
> file name, instead of comma-separated tli, xlogid, segno arguments. The
> latter is a bit meaningless now that we don't use the xlogid+segno
> combination anywhere else. Alvaro pointed out that pg_upgrade was broken
> by the change in pg_resetxlog -n output - I changed that too to print
> the "First log segment after reset" information as a WAL file name,
> instead of logid+segno. Another option would be to print the 64-bit
> segment number, but I think that's worse, because the 64-bit segment
> number is harder to associate with a physical WAL file.
>
> So I think we should change pg_resetxlog -l option to take a WAL file
> name as argument, and fix pg_upgrade accordingly.
The only thing pg_upgrade does with the tli/logid/segno combo, AFAICT,
is pass it back to pg_resetxlog -l, so this plan seems reasonable.
--
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@commandprompt.com, heikki.linnakangas@enterprisedb.com, robertmhaas@gmail.com, masao.fujii@gmail.com, andres@2ndquadrant.com
Subject: Re: WAL format changes
In-Reply-To: <1340671279-sup-3382@alvh.no-ip.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox