pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Andres Freund <andres@anarazel.de>
Cc: David Rowley <dgrowleyml@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Intermittent buildfarm failures on wrasse
Date: Wed, 13 Apr 2022 20:35:50 -0400
Message-ID: <1374062.1649896550@sss.pgh.pa.us> (raw)
In-Reply-To: <CAH2-Wzn2Obp90oyZa5HN26rzG8ozzHM3dgkpLcsVzxTR+jK5NQ@mail.gmail.com>
References: <1346227.1649887693@sss.pgh.pa.us>
	<CAH2-WzkVEJWgJ6FrPd0jNiFo3e4kADNYSDSnQXWQbktqWPZfkA@mail.gmail.com>
	<1349964.1649890446@sss.pgh.pa.us>
	<CAApHDvrHtXtDCjbdRLJAKOO6warCd4WELxK9tq0mUz3u1OaLOg@mail.gmail.com>
	<9F59C4BB-3C82-44B0-9B10-4A2CCC3DE552@anarazel.de>
	<CAH2-WzmOJ5YeT1SsBZ7kp2B+EMMVH9RYShornT13oyduEVwKSw@mail.gmail.com>
	<1364997.1649893086@sss.pgh.pa.us>
	<CAH2-WzkUGqFNXhnFRbVG4xfTo3WpapcdRaH4hQSTrNvDgYvYoQ@mail.gmail.com>
	<1365924.1649893883@sss.pgh.pa.us>
	<CAH2-Wzn2Obp90oyZa5HN26rzG8ozzHM3dgkpLcsVzxTR+jK5NQ@mail.gmail.com>

Peter Geoghegan <pg@bowt.ie> writes:
> On Wed, Apr 13, 2022 at 4:51 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Yeah, we have band-aided around this type of problem repeatedly.
>> Making a fix that's readily accessible from any test script
>> seems like a good idea.

> We might even be able to consistently rely on this new option, given
> *any* problem involving test stability and VACUUM. Having a
> one-size-fits-all solution to these kinds of stability problems would
> be nice -- no more DISABLE_PAGE_SKIPPING bandaids.

My guess is that you'd need both this new wait-for-horizon behavior
*and* DISABLE_PAGE_SKIPPING.  But the two together ought to make
for pretty reproducible behavior.  I noticed while scanning the
commit log that some patches have tried adding a FREEZE option,
which seems more like waving a dead chicken than anything that'd
improve stability.

We'd not necessarily have to embed wait-for-horizon into VACUUM
itself.  It seems like a SQL-accessible function could be written
and then called before any problematic VACUUM.  I like this better
for something we're thinking of jamming in post-feature-freeze;
we'd not be committing to the feature quite as much as if we
added a VACUUM option.

			regards, tom lane





view thread (88+ messages)  latest in thread

Message-ID: <1374062.1649896550@sss.pgh.pa.us>
Permalink:  ../1374062.1649896550@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1374062.1649896550@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pg@bowt.ie, andres@anarazel.de, dgrowleyml@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Intermittent buildfarm failures on wrasse
  In-Reply-To: <1374062.1649896550@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox