From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Buildfarm failure and dubious coding in predicate.c
Date: Mon, 24 Jul 2017 15:24:01 -0400
Message-ID: <1376.1500924241@sss.pgh.pa.us> (raw)
In-Reply-To: <CAEepm=2x6QaWZx7U7=exeSQJKBZbmRhH4AVAQYDx=Jik5W_C6g@mail.gmail.com>
References: <10593.1500670709@sss.pgh.pa.us>
<21591.1500755559@sss.pgh.pa.us>
<CAEepm=2RN2AEksa2v=5cPQhO1awM-J5=CMK4GBKKvDb=vN9wPg@mail.gmail.com>
<CAEepm=2x6QaWZx7U7=exeSQJKBZbmRhH4AVAQYDx=Jik5W_C6g@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Thomas Munro <thomas.munro@enterprisedb.com> writes:
> Ahh, I think I see it. This is an EXEC_BACKEND build farm animal.
> Theory: After the backend we see had removed the scratch entry and
> before it had restored it, another backend started up and ran
> InitPredicateLocks(), which inserted a new scratch entry without
> interlocking.
Ouch. Yes, I think you're probably right. It needs to skip that if
IsUnderPostmaster. Seems like there ought to be an Assert(!found)
there, too. And I don't think I entirely like the fact that there's
no assertions about the found/not found cases below, either.
Will fix, unless you're already on it?
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, thomas.munro@enterprisedb.com
Subject: Re: Buildfarm failure and dubious coding in predicate.c
In-Reply-To: <1376.1500924241@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox