public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Tomas Vondra <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Shouldn't construct_array_builtin and deconstruct_array_builtin agree on types?
Date: Mon, 12 Jun 2023 20:26:45 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>

Michael Paquier <[email protected]> writes:
> On Mon, Jun 12, 2023 at 11:06:18PM +0200, Peter Eisentraut wrote:
>> They only support the types that they were actually being used with.  If you
>> need another type, feel free to add it.

> FWIW, I agree with Tomas that this is an oversight that should be
> fixed in v16, saving from the need to have a copy of
> deconstruct_array_builtin() in extensions.

We don't want to bloat these functions indefinitely, so I understand
Peter's approach of only adding the cases actually being used.
At the same time, it's reasonable to take some thought for extensions
that might want slightly more functionality than the core code
happens to need at any given moment.

The idea of making both functions support the same set of types
does seem like a reasonable compromise.

			regards, tom lane

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Shouldn't construct_array_builtin and deconstruct_array_builtin agree on types?
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox