public inbox for [email protected]help / color / mirror / Atom feed
[PATCH v4 3/3] Fix timeline-tracking failure while sending a historic timeline 2+ messages / 2 participants [nested] [flat]
* [PATCH v4 3/3] Fix timeline-tracking failure while sending a historic timeline @ 2020-12-09 08:22 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 2+ messages in thread From: Kyotaro Horiguchi @ 2020-12-09 08:22 UTC (permalink / raw) Walsender should track timeline switches while sending a historic timeline. Regain that behavior, which was broken in PG13, by a thinko of 709d003fbd. --- src/backend/replication/walsender.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/replication/walsender.c b/src/backend/replication/walsender.c index fe0d368a35..8545c6c423 100644 --- a/src/backend/replication/walsender.c +++ b/src/backend/replication/walsender.c @@ -2491,7 +2491,7 @@ WalSndSegmentOpen(XLogReaderState *state, XLogSegNo nextSegNo, XLogSegNo endSegNo; XLByteToSeg(sendTimeLineValidUpto, endSegNo, state->segcxt.ws_segsize); - if (state->seg.ws_segno == endSegNo) + if (nextSegNo == endSegNo) *tli_p = sendTimeLineNextTLI; } -- 2.27.0 ----Next_Part(Thu_Jan__7_16_32_36_2021_122)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="0001-Fix-timeline-tracking-failure-while-sending-a-PG13.patch.txt" ^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: Shouldn't construct_array_builtin and deconstruct_array_builtin agree on types? @ 2023-06-13 00:26 Tom Lane <[email protected]> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2023-06-13 00:26 UTC (permalink / raw) To: Michael Paquier <[email protected]>; +Cc: Peter Eisentraut <[email protected]>; Tomas Vondra <[email protected]>; PostgreSQL Hackers <[email protected]> Michael Paquier <[email protected]> writes: > On Mon, Jun 12, 2023 at 11:06:18PM +0200, Peter Eisentraut wrote: >> They only support the types that they were actually being used with. If you >> need another type, feel free to add it. > FWIW, I agree with Tomas that this is an oversight that should be > fixed in v16, saving from the need to have a copy of > deconstruct_array_builtin() in extensions. We don't want to bloat these functions indefinitely, so I understand Peter's approach of only adding the cases actually being used. At the same time, it's reasonable to take some thought for extensions that might want slightly more functionality than the core code happens to need at any given moment. The idea of making both functions support the same set of types does seem like a reasonable compromise. regards, tom lane ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2023-06-13 00:26 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2020-12-09 08:22 [PATCH v4 3/3] Fix timeline-tracking failure while sending a historic timeline Kyotaro Horiguchi <[email protected]> 2023-06-13 00:26 Re: Shouldn't construct_array_builtin and deconstruct_array_builtin agree on types? Tom Lane <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox