public inbox for [email protected]
help / color / mirror / Atom feedFrom: Peter Eisentraut <[email protected]>
To: Paul A Jungwirth <[email protected]>
To: Chao Li <[email protected]>
Cc: jian he <[email protected]>
Cc: SATYANARAYANA NARLAPURAM <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: FOR PORTION OF does not recompute GENERATED STORED columns that depend on the range column
Date: Thu, 4 Jun 2026 11:58:48 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+renyXyLfvtvVv--hGWGTgzFP=-+dPLy4RWvEmioAPyJMM+uw@mail.gmail.com>
References: <CAHg+QDcd=t69gLf9yQexO07EJ2mx0Z70NFHo6h94X1EDA=hM0g@mail.gmail.com>
<CACJufxEkomKYmWgqXJmQr_qS+z=BZ3w801eh7Z7ekh-3oHXxHQ@mail.gmail.com>
<CA+renyWk7kVsZJPZKzN95mYkO7S=hDUx=+fUPtbg9qFqeepCpg@mail.gmail.com>
<CACJufxHai+HB1gkNqVEHe4oKyUmXfAagWBYAWXYKy8hyMV3RxA@mail.gmail.com>
<CA+renyUBQdhnYxfPay+dxFs6BU1-fnEQskT0r-3dQ2v-ZnmZzg@mail.gmail.com>
<CA+renyVZLYSghHb_85w0pUBG0KNGKTwciFTKBK5--rpHUM+VdA@mail.gmail.com>
<[email protected]>
<CA+renyU6rNkiNGreMyQ7pU_F6-5RND5jchHbECH4NoRO7W0Q-Q@mail.gmail.com>
<[email protected]>
<[email protected]>
<[email protected]>
<CA+renyUBLAynaj0BKhajB6F=sLuitQkjT+_sOt5HBSRn82iQsw@mail.gmail.com>
<[email protected]>
<CA+renyUTzwAMar173cbbxJypChp7s=txxgB+LYJQ5oRZ3a5hYQ@mail.gmail.com>
<CA+renyXyLfvtvVv--hGWGTgzFP=-+dPLy4RWvEmioAPyJMM+uw@mail.gmail.com>
On 26.05.26 00:23, Paul A Jungwirth wrote:
> On Fri, May 8, 2026 at 8:25 AM Paul A Jungwirth
> <[email protected]> wrote:
>>
>> On Fri, May 8, 2026 at 12:10 AM Chao Li <[email protected]> wrote:
>>>> <v11-0001-Fix-FOR-PORTION-OF-column-dependency-tracking.patch><v11-0002-Fix-FOR-PORTION-OF-with-partitions-and-inheritan.patch>
>>>
>>> Thanks for updating the patch and making the separation. After reading v11, I still have a few comments for 0001.
>> . . .
>>
>> v12 attached.
>
> After discussing this as PGConf.dev, Peter and I agreed that we
> *should* be checking for UPDATE permission on the application-time
> column. So we need to add the attno to updatedCols on the
> RTEPermissionInfo. That is great, because it fixes GENERATED column
> dependency tracking and also UPDATE OF triggers, without the
> complexity of changing ExecGetUpdatedCols.
>
> Note we still do not require INSERT permission for the temporal
> leftovers, which is what the SQL Standard says and also makes sense
> semantically, since those leftovers represent already-existing
> history.
>
> No RLS changes are needed because RLS policies aren't checked based on
> *column* changes.
>
> We still need a fix for non-partitioning inheritance, but the patch
> becomes a lot simpler.
>
> Here is a patch adding the application-time column to updatedCols,
> along with the tests we've written for GENERATED columns and UPDATE OF
> triggers.
committed
view thread (32+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: FOR PORTION OF does not recompute GENERATED STORED columns that depend on the range column
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox