pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Craig Ringer <craig@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Timing-sensitive case in src/test/recovery TAP tests
Date: Mon, 26 Jun 2017 14:44:02 -0400
Message-ID: <14061.1498502642@sss.pgh.pa.us> (raw)
In-Reply-To: <CAB7nPqRapQBG8BSUR=UkShJDXCyPYD+GcBNmgSzu4Lw==UzAeQ@mail.gmail.com>
References: <8962.1498425057@sss.pgh.pa.us>
	<CAMsr+YELP+j4OypCoYtRL_Z-KoYrDc+RdqX56mvTBTPqL_55VA@mail.gmail.com>
	<CAB7nPqSZ=YZJeW7m73m+03faPvwykRaQ13fkTOJaV8sym+us_A@mail.gmail.com>
	<17089.1498442945@sss.pgh.pa.us>
	<CAMsr+YE6JEuUAmT657Zq+ix_+6miY3psB7tDZnw8-43LdsB69A@mail.gmail.com>
	<CAB7nPqSfqN_Y16nLSMRVfDM7OAnWJ7mOCxgQZ_zip95sNjZ_Xw@mail.gmail.com>
	<CAMsr+YEbb5rxgZRfCdUbUJwF7rEmbmSVKTbyqYBj48rOARhO=w@mail.gmail.com>
	<CAB7nPqRapQBG8BSUR=UkShJDXCyPYD+GcBNmgSzu4Lw==UzAeQ@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Michael Paquier <michael.paquier@gmail.com> writes:
> On Mon, Jun 26, 2017 at 12:12 PM, Craig Ringer <craig@2ndquadrant.com> wrote:
>> I'm not sure I understand this.

> The patch attached may explain that better. Your patch added 3 poll
> phases. I think that a 4th is needed. At the same time I have found
> cleaner to put the poll calls into a small wrapper.

Looks good as far as it goes, but I wonder whether any of the other
get_slot_xmins calls need polling too.  Don't feel a need to add such
calls until someone exhibits a failure there, but I won't be very
surprised if someone does.

Anyway, pushed this patch with minor editing.  Thanks!

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (16+ messages)  latest in thread

Message-ID: <14061.1498502642@sss.pgh.pa.us>
Permalink:  ../14061.1498502642@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/14061.1498502642@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, michael.paquier@gmail.com, craig@2ndquadrant.com
  Subject: Re: Timing-sensitive case in src/test/recovery TAP tests
  In-Reply-To: <14061.1498502642@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox