From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-hackers@postgreSQL.org
Cc: Jan Wieck <jan@wi3ck.info>
Subject: Re: I propose killing PL/Tcl's "modules" infrastructure
Date: Sun, 26 Feb 2017 13:09:31 -0500
Message-ID: <14094.1488132571@sss.pgh.pa.us> (raw)
In-Reply-To: <22067.1488046447@sss.pgh.pa.us>
References: <22067.1488046447@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
I wrote:
> Now, we could try to fix this bug, and add the regression test coverage
> that the code clearly lacks, and upgrade the documentation about it from
> its currently very sad state. But I think the right answer is just to
> remove the feature altogether.
BTW, I tried to poke into what it would take to write some regression test
coverage, and immediately hit a show-stopper:
$ pltcl_loadmod --help
can't find package Pgtcl
while executing
"package require Pgtcl"
(file "/home/postgres/testversion/bin/pltcl_loadmod" line 10)
That is, these scripts depend on the old Tcl client library, which
we removed from our core distro in 2004 (cf commit 41fa9e9ba).
So we don't even have a way of creating self-contained tests for them.
At this point I think there's no question that src/pl/tcl/modules/
needs to go away. There might be some argument for retaining the
"autoload the unknown module" startup behavior in pltcl proper, but
I think that Andrew Dunstan's proposal of calling an initialization
function is a far cleaner solution.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, jan@wi3ck.info
Subject: Re: I propose killing PL/Tcl's "modules" infrastructure
In-Reply-To: <14094.1488132571@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox