pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Noah Misch <noah@leadboat.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: AIX support - alignment issues
Date: Sun, 03 Jul 2022 20:47:21 -0400
Message-ID: <1420389.1656895641@sss.pgh.pa.us> (raw)
In-Reply-To: <20220704004332.y3vcm5btn5h5fbpp@awork3.anarazel.de>
References: <20220702183354.a6uhja35wta7agew@alap3.anarazel.de>
	<CAH2-WzndKXQQGh-7sCOTKL_87Kt918r0F2ztTAraeBCAC8v3OQ@mail.gmail.com>
	<968410.1656789743@sss.pgh.pa.us>
	<CAH2-WzmnoGPN--Z7MfTqv2TTVLJF0Y0tzZbGUS-NAwJ0wv15hw@mail.gmail.com>
	<977853.1656794075@sss.pgh.pa.us>
	<CA+hUKGLo8XVq4c=QpXFO5i3t3u5q6Fope=QgRtE-S3RncP+aUg@mail.gmail.com>
	<1415825.1656893299@sss.pgh.pa.us>
	<20220704004332.y3vcm5btn5h5fbpp@awork3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> On 2022-07-03 20:08:19 -0400, Tom Lane wrote:
>> I do still feel that HPPA is of interest, to keep us honest
>> about spinlock support

> I.e. forgetting to initialize them? Or the weird alignment stuff it has?

The nonzero initialization mainly, and to a lesser extent the weird
size of a lock.  I think the fact that the active word is only part
of the lock struct is pretty well encapsulated.

> I'd started to work a patch to detect missing initialization for both
> spinlocks and lwlocks, I think that'd be good to have for more common cases.

No objection to having more than one check for this ;-)

			regards, tom lane





view thread (48+ messages)  latest in thread

Message-ID: <1420389.1656895641@sss.pgh.pa.us>
Permalink:  ../1420389.1656895641@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1420389.1656895641@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, thomas.munro@gmail.com, pg@bowt.ie, noah@leadboat.com, robertmhaas@gmail.com
  Subject: Re: AIX support - alignment issues
  In-Reply-To: <1420389.1656895641@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox