From: Tom Lane <tgl@sss.pgh.pa.us>
To: Etsuro Fujita <etsuro.fujita@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Bogus EXPLAIN results with column aliases for mismatched partitions
Date: Tue, 03 Dec 2019 12:12:09 -0500
Message-ID: <14353.1575393129@sss.pgh.pa.us> (raw)
In-Reply-To: <CAPmGK16+XskOXty=y+GP5B0MXs1o8gACq=qVbzbC3fRYrkByrA@mail.gmail.com>
References: <12424.1575168015@sss.pgh.pa.us>
<4257.1575229116@sss.pgh.pa.us>
<10395.1575236078@sss.pgh.pa.us>
<CAPmGK15KSu5DkFjRJ96PHVmwti9FSvbMnM2_d2=GXx4iw_jrxw@mail.gmail.com>
<23961.1575297703@sss.pgh.pa.us>
<8343.1575323118@sss.pgh.pa.us>
<CAPmGK16+XskOXty=y+GP5B0MXs1o8gACq=qVbzbC3fRYrkByrA@mail.gmail.com>
Etsuro Fujita <etsuro.fujita@gmail.com> writes:
> On Tue, Dec 3, 2019 at 6:45 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Concretely, I'm thinking of the attached (on top of the other patch,
>> which I just pushed). This agrees exactly with what ExplainTargetRel
>> does for regular scans.
> Thanks for the patch! (The patch didn't apply to HEAD cleanly,
> though.) I like consistency, so +1 for the change.
Yeah, 55a1954da probably changed the expected output from what that
has. I'll clean it up and push.
>> One could make an argument that we should schema-qualify, regardless
>> of the "verbose" flag, if the output format isn't EXPLAIN_FORMAT_TEXT.
>> That would reduce the amount of variability that plan analysis tools
>> have to cope with. However, ExplainTargetRel itself doesn't provide
>> the schema in non-verbose mode. Maybe it should, ie we should change
>> it like ...
> Seems like another issue to me.
Agreed. When/if we change that, we could make this code follow along.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, etsuro.fujita@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Bogus EXPLAIN results with column aliases for mismatched partitions
In-Reply-To: <14353.1575393129@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox