From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Steven Pousty <steve.pousty@gmail.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Isaac Morland <isaac.morland@gmail.com>
Cc: Pierre Giraud <pierre.giraud@dalibo.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Poll: are people okay with function/operator table redesign?
Date: Sat, 18 Apr 2020 16:36:17 -0400
Message-ID: <14380.1587242177@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmoZrYwfh4bU+OyhvdvHADBay6CcsseA74vtj8gO_mKOmNQ@mail.gmail.com>
References: <20200416230304.GA28390@alvherre.pgsql>
<17560.1587083109@sss.pgh.pa.us>
<CA+TgmoYP2Lx=e1EbkJo-EVH6nWP8=+Rbu=u3LcnzWvh=VY47zA@mail.gmail.com>
<20266.1587148695@sss.pgh.pa.us>
<CAKFQuwamrEtOp2swR38MWNNYatu_L2YUMjNO=Nw3kKRvMymOCQ@mail.gmail.com>
<CA+TgmoZrYwfh4bU+OyhvdvHADBay6CcsseA74vtj8gO_mKOmNQ@mail.gmail.com>
Robert Haas <robertmhaas@gmail.com> writes:
> On Fri, Apr 17, 2020 at 6:30 PM David G. Johnston
> <david.g.johnston@gmail.com> wrote:
>> I feel like writing them as:
>> + (date, integer) -> date
>> makes more sense as they are mainly sorted on the operator symbol as opposed to the left operand.
> I thought about that, too, but I think the way Tom did it is better.
> It's much more natural to see it using the syntax with which it will
> actually be invoked.
Just for the record, I experimented with putting back an "operator name"
column, as attached. I think it could be argued either way whether this
is an improvement or not.
Some notes:
* The column seems annoyingly wide, but the only way to make it narrower
is to narrow or eliminate the column title, which could be confusing.
Also, if there's not a fair amount of whitespace, it looks as if the
initial name is part of the signature, which is *really* confusing,
cf second screenshot. (I'm not sure why the vertical rule is rendered
so much more weakly in this case, but it is.)
* I also tried it with valign="middle" to center the operator name among
its entries. This was *not* an improvement, it largely breaks the
ability to see which entries belong to the name.
regards, tom lane
Attachments:table-9.30-with-names.png (image/png, 250.5K) downloadview imagetable-9.30-no-header.png (image/png, 238.4K) downloadview image
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, david.g.johnston@gmail.com, alvherre@2ndquadrant.com, steve.pousty@gmail.com, pavel.stehule@gmail.com, isaac.morland@gmail.com, pierre.giraud@dalibo.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Poll: are people okay with function/operator table redesign?
In-Reply-To: <14380.1587242177@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox