From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: GCC 7 warnings
Date: Mon, 10 Apr 2017 12:25:59 -0400
Message-ID: <14447.1491841559@sss.pgh.pa.us> (raw)
In-Reply-To: <dd7e5c64-86ec-9e96-e682-a57d1cb9bcc2@2ndquadrant.com>
References: <dd7e5c64-86ec-9e96-e682-a57d1cb9bcc2@2ndquadrant.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> Possible fixes:
> a) Ignore, hoping GCC will change before final release. (unlikely at
> this point)
> b) Add compiler option to disable this particular warning, worry about
> it later. (Might be an option for backpatching.)
> c) Expand the target buffer sizes until the warning goes away. (Sample
> patch attached.)
> d) Replace most of the problematic code with psprintf() and dynamically
> sized buffers.
+1 for (c) as you have it. Later we might think about selectively
doing (d), but it seems like more work for probably not much benefit.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com
Subject: Re: GCC 7 warnings
In-Reply-To: <14447.1491841559@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox