pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Chao Li <li.evan.chao@gmail.com>
Cc: Joel Jacobson <joel@compiler.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Improve hash join's handling of tuples with null join keys
Date: Thu, 19 Mar 2026 15:24:36 -0400
Message-ID: <1449781.1773948276@sss.pgh.pa.us> (raw)
In-Reply-To: <375DCE57-1107-48B7-9A64-3B3FC24CCECD@gmail.com>
References: <3061845.1746486714@sss.pgh.pa.us>
	<496221.1748882849@sss.pgh.pa.us>
	<175507656113.993.1381684440543440253.pgcf@coridan.postgresql.org>
	<544D7C83-CECE-44E7-B5D7-530E9318D231@gmail.com>
	<616751.1755276726@sss.pgh.pa.us>
	<5C5EE031-F086-4353-A17A-DA563CD24DDD@gmail.com>
	<463296.1755553046@sss.pgh.pa.us>
	<659B2B36-C0FE-4642-921D-E7120E838891@gmail.com>
	<52163.1755988628@sss.pgh.pa.us>
	<1290278.1772571496@sss.pgh.pa.us>
	<3ccec807-d2ff-4150-9585-74cc52926646@app.fastmail.com>
	<940201.1773861007@sss.pgh.pa.us>
	<375DCE57-1107-48B7-9A64-3B3FC24CCECD@gmail.com>

Chao Li <li.evan.chao@gmail.com> writes:
> Overall, this looks like a solid patch to me.

Thanks for taking another look.

> The only thing I noticed is that while 0002 fixes the tuple-counting issue, there does not seem to be a test that would fail without it. So I think it would be better to add a test case for 0002. I tried doing that and attached a diff. Without 0002, the test fails; with 0002, it passes.

I couldn't get excited about expending test cycles on that.

			regards, tom lane





view thread (19+ messages)

Message-ID: <1449781.1773948276@sss.pgh.pa.us>
Permalink:  ../1449781.1773948276@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1449781.1773948276@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, li.evan.chao@gmail.com, joel@compiler.org
  Subject: Re: Improve hash join's handling of tuples with null join keys
  In-Reply-To: <1449781.1773948276@sss.pgh.pa.us>
  References: <3061845.1746486714@sss.pgh.pa.us> <496221.1748882849@sss.pgh.pa.us> <175507656113.993.1381684440543440253.pgcf@coridan.postgresql.org> <544D7C83-CECE-44E7-B5D7-530E9318D231@gmail.com> <616751.1755276726@sss.pgh.pa.us> <5C5EE031-F086-4353-A17A-DA563CD24DDD@gmail.com> <463296.1755553046@sss.pgh.pa.us> <659B2B36-C0FE-4642-921D-E7120E838891@gmail.com> <52163.1755988628@sss.pgh.pa.us> <1290278.1772571496@sss.pgh.pa.us> <3ccec807-d2ff-4150-9585-74cc52926646@app.fastmail.com> <940201.1773861007@sss.pgh.pa.us> <375DCE57-1107-48B7-9A64-3B3FC24CCECD@gmail.com> <1449781.1773948276@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox