pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: PRI?64 vs Visual Studio (2022)
Date: Wed, 19 Nov 2025 10:43:58 -0500
Message-ID: <1462038.1763567038@sss.pgh.pa.us> (raw)
In-Reply-To: <e7b902aa-98ac-4d35-bae3-d7d282a938c2@eisentraut.org>
References: <20250331.152829.1921392690375275165.horikyota.ntt@gmail.com>
	<001bdc3b-ef94-4f24-b017-ac8ff0a2ea55@eisentraut.org>
	<CA+hUKGJnmzTqiODmTjf-23yZ=E3HXqFTtKoyp3TF-MpB93hTMQ@mail.gmail.com>
	<1372793.1763519315@sss.pgh.pa.us>
	<CA+hUKGLzXzQcbjEHW08Z6g=mzBkpLtzSJ7Bt2S2XmxP1bwpq8A@mail.gmail.com>
	<1377512.1763522154@sss.pgh.pa.us>
	<e7b902aa-98ac-4d35-bae3-d7d282a938c2@eisentraut.org>

Peter Eisentraut <peter@eisentraut.org> writes:
> On 19.11.25 04:15, Tom Lane wrote:
>> I think we should do it
>> honestly with a regression test.  It doesn't need to be very
>> complicated --- I think checking one message in one translation is
>> sufficient, so long as it includes a PRI?64 usage.

> We could generate an English message catalog that translates all 
> messages unchanged, and run the whole test suite with that.  This would 
> exercise the whole gettext run-time machinery.

... except that if it were actually doing nothing whatsoever, you
could not tell.  This seems particularly troublesome for gettext,
since its fallback behavior is exactly to return the given string.
I'd prefer a test that fails in a visible way.

			regards, tom lane





view thread (41+ messages)  latest in thread

Message-ID: <1462038.1763567038@sss.pgh.pa.us>
Permalink:  ../1462038.1763567038@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1462038.1763567038@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, peter@eisentraut.org, thomas.munro@gmail.com, horikyota.ntt@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: PRI?64 vs Visual Studio (2022)
  In-Reply-To: <1462038.1763567038@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox