From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: legrand legrand <legrand_legrand@hotmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Patch: to pass query string to pg_plan_query()
Date: Thu, 26 Mar 2020 11:44:44 -0400
Message-ID: <14854.1585237484@sss.pgh.pa.us> (raw)
In-Reply-To: <6ecbaaca-5a8e-5fe6-f7e1-a893e708bd7b@oss.nttdata.com>
References: <1583789487074-0.post@n3.nabble.com>
<6ecbaaca-5a8e-5fe6-f7e1-a893e708bd7b@oss.nttdata.com>
Fujii Masao <masao.fujii@oss.nttdata.com> writes:
> Does anyone object to this patch? I'm thinking to commit it separetely
> at first before committing the planning_counter_in_pg_stat_statements
> patch.
I took a quick look through v9-0001-Pass-query-string-to-the-planner.patch
and it's fine by me. It also matches up with something I've wanted to
do for awhile, which is to make the query string available during
planning and execution so that we can produce error cursors for
run-time errors, when relevant.
(It's a little weird that the patch doesn't make standard_planner
actually *do* anything with the string, like say save it into
the PlannerInfo struct. But that can come later I guess.)
Note that I wouldn't want to bet that all of these call sites always have
non-null query strings to pass; but probably most of the time they will.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, masao.fujii@oss.nttdata.com, legrand_legrand@hotmail.com
Subject: Re: Patch: to pass query string to pg_plan_query()
In-Reply-To: <14854.1585237484@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox