pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Banck <michael.banck@credativ.de>
To: Magnus Hagander <magnus@hagander.net>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Jim Nasby <Jim.Nasby@bluetreble.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: gitlab post-mortem: pg_basebackup waiting for checkpoint
Date: Sun, 26 Feb 2017 21:53:46 +0100
Message-ID: <1488142426.24065.10.camel@credativ.de> (raw)
In-Reply-To: <CABUevEzxrh0tFeUof=S-AL2t5aNVAqbL2jpaSwpMGSXazgV1sQ@mail.gmail.com>
References: <CA+TgmoZ2Ru__LmeNQJm3AjGPHBHjfhU0D+X5pTw7UdZtvK2qhQ@mail.gmail.com>
	<20170214210651.ldwzk6frxxclbomw@alvherre.pgsql>
	<CA+TgmoYeTytkZdSQqX8Ck+ZHSQkW5dyY8-0=rCdofxUbjdya_A@mail.gmail.com>
	<1488137223.24065.7.camel@credativ.de>
	<CABUevEzxrh0tFeUof=S-AL2t5aNVAqbL2jpaSwpMGSXazgV1sQ@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Hi,

Am Sonntag, den 26.02.2017, 21:32 +0100 schrieb Magnus Hagander:

> On Sun, Feb 26, 2017 at 8:27 PM, Michael Banck
> <michael.banck@credativ.de> wrote:

> Agreed, and applied as one patch. Except I noticed you also fixed a
> couple of entries which were missing the progname in the messages -- I
> broke those out to a separate patch instead.

Thanks!

> Made a small change to "using as much I/O as available" rather than
> "as possible", which I think is a better wording, along with the
> change of the idle wording I suggested before. (but feel free to point
> it out to me if that's wrong). 

LGTM, I apparently missed your suggestion when I re-read the thread.

I am just wondering whether this could/should be back-patched, maybe? It
is not a bug fix, of course, but OTOH is rather small and probably
helpful to some users on current releases.


Michael

-- 
Michael Banck
Projektleiter / Senior Berater
Tel.: +49 2166 9901-171
Fax:  +49 2166 9901-100
Email: michael.banck@credativ.de

credativ GmbH, HRB Mönchengladbach 12080
USt-ID-Nummer: DE204566209
Trompeterallee 108, 41189 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer




-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (30+ messages)  latest in thread

Message-ID: <1488142426.24065.10.camel@credativ.de>
Permalink:  ../1488142426.24065.10.camel@credativ.de/
Also on:    postgresql.org/message-id/1488142426.24065.10.camel@credativ.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael.banck@credativ.de, magnus@hagander.net, robertmhaas@gmail.com, alvherre@2ndquadrant.com, Jim.Nasby@bluetreble.com
  Subject: Re: gitlab post-mortem: pg_basebackup waiting for checkpoint
  In-Reply-To: <1488142426.24065.10.camel@credativ.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox