public inbox for [email protected]
help / color / mirror / Atom feedFrom: Andrey Borodin <[email protected]>
To: Kirill Reshke <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: Fix gistkillitems & add regression test to microvacuum
Date: Tue, 27 Jan 2026 12:26:01 +0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <CALdSSPiGnqgvpfQDCydBf-=0hzyUs6Y0o0xNvd53BbcMWTVO=w@mail.gmail.com>
References: <CALdSSPgZWX_D8+Fx4YQqRN5eW5iSx_rJdqQhCfdWTvqKXVfJ4w@mail.gmail.com>
<CALdSSPgPs=gKWkKN0=4yBd49FBY=ijxBz4YGV64vfVMK7YQhpw@mail.gmail.com>
<CALdSSPiaQptrccvRoHhP3=YqN9-K8duXfLHHm3G=+7FVL8A-Xw@mail.gmail.com>
<CALdSSPh-QtT8NrhtKsNWwFVF3D4KX6Wy3qs-FPc16c6VAECEyg@mail.gmail.com>
<CALdSSPgfFWUBc8RoOZe5PmoUGa4LJUDeMTcAT8HwXGCMGJ9uBA@mail.gmail.com>
<[email protected]>
<CALdSSPiGnqgvpfQDCydBf-=0hzyUs6Y0o0xNvd53BbcMWTVO=w@mail.gmail.com>
> On 23 Jan 2026, at 16:03, Kirill Reshke <[email protected]> wrote:
>
> On Tue, 20 Jan 2026 at 15:30, Andrey Borodin <[email protected]> wrote:
>>
>>
>>
>>> On 15 Jan 2026, at 22:59, Kirill Reshke <[email protected]> wrote:
>>>
>>> PFA v2 which leaves the test in-place.
>>>
>>> Also commit message improvements.
>>
>> Yeah, killtuples for GiST root page is broken. Your patch is fixing it.
>> I don't think we should backpatch this, the bug is harmless, but for master the patch LGTM.
>
> Thank you
>
>> It would be good to assign so->curBlkno and so->curBlkno together. But gistScanPage() is the only place with access to the block number.
>
> Sorry, didnt get this take.
Sorry, I meant so->curBlkno and so->numKilled are semantically correlated. But it's difficult to assign them together and this does not worth refactoring.
>
>> +# Test gist, but with fewer rows - that killitems used to be buggy.
>>
>> Probably, in this comment we can explicitly say that killitems was buggy, but now is fixed.
>>
>
> Hmm, what would be a good wording here?
I've opened an English dictionary and it says "used to" can be used with a meaning "bug was there but it's not anymore".
So the patch is RfC IMO.
Best regards, Andrey Borodin.
view thread (6+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: Fix gistkillitems & add regression test to microvacuum
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox