From: Bossart, Nathan <bossartn@amazon.com>
To: Michael Paquier <michael@paquier.xyz>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Stephen Frost <sfrost@snowman.net>
Subject: Re: archive modules
Date: Tue, 2 Nov 2021 15:14:01 +0000
Message-ID: <14CD3884-6D82-4928-83A2-265B1F539B29@amazon.com> (raw)
In-Reply-To: <YYDLd7vsmrYHC+9C@paquier.xyz>
References: <668D2428-F73B-475E-87AE-F89D67942270@amazon.com>
<e437bf15-9917-7b78-f326-90b9c57ba8ae@oss.nttdata.com>
<YYDLd7vsmrYHC+9C@paquier.xyz>
I've just realized I forgot to CC the active participants on the last
thread to this one, so I've attempted to do that now. I didn't
intentionally leave anyone out, but I'm sorry if I missed someone.
On 11/1/21, 10:24 PM, "Michael Paquier" <michael@paquier.xyz> wrote:
> It seems to me that this patch is not moving into the right direction
> implementation-wise (I have read the arguments about
> backward-compatibility that led to the introduction of archive_library
> and its shell mode), for what looks like a duplicate of
> shared_preload_libraries but for an extra code path dedicated to the
> archiver, where we could just have a hook instead? We have been
> talking for some time now to make the archiver process more
> bgworker-ish, so as we finish with something closer to what the
> logical replication launcher is.
Hm. It sounds like you want something more like what was discussed
earlier in the other thread [0]. This approach would basically just
add a hook and call it a day. My patch for this approach [1] moved
the shell archive logic to a test module, but the general consensus
seems to be that we'd need to have it be present in core (and the
default).
Nathan
[0] https://postgr.es/m/8B7BF404-29D4-4662-A2DF-1AC4C98463EB%40amazon.com
[1] https://postgr.es/m/attachment/127385/v2-0001-Replace-archive_command-with-a-hook.patch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: bossartn@amazon.com, michael@paquier.xyz, masao.fujii@oss.nttdata.com, robertmhaas@gmail.com, magnus@hagander.net, sfrost@snowman.net
Subject: Re: archive modules
In-Reply-To: <14CD3884-6D82-4928-83A2-265B1F539B29@amazon.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox