From: Tomas Vondra <tomas.vondra@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Alexander Lakhin <exclusion@gmail.com>
Cc: Soumyadeep Chakraborty <soumyadeep2007@gmail.com>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Ashwin Agrawal <ashwinstar@gmail.com>
Subject: Re: brininsert optimization opportunity
Date: Thu, 18 Apr 2024 11:35:43 +0200
Message-ID: <14e52b46-a802-4035-b33a-627968e14375@enterprisedb.com> (raw)
In-Reply-To: <ZiDGzZ5zoHXJgMVZ@paquier.xyz>
References: <f412087a-6ef9-4b84-941a-e42f43150070@enterprisedb.com>
<202402291220.gmjxa5wohzsh@alvherre.pgsql>
<ZiDGzZ5zoHXJgMVZ@paquier.xyz>
On 4/18/24 09:07, Michael Paquier wrote:
> On Thu, Feb 29, 2024 at 01:20:39PM +0100, Alvaro Herrera wrote:
>> I think it's not an issue, or rather that we should not try to guess.
>> Instead make it a simple rule: if aminsert is called, then
>> aminsertcleanup must be called afterwards, period.
>>
>> I agree it would be nice to have a way to verify, but it doesn't seem
>> 100% essential. After all, it's not very common to add new calls to
>> aminsert.
>
> This thread is listed as an open item. What's the follow-up plan?
> The last email of this thread is dated as of the 29th of February,
> which was 6 weeks ago.
Apologies, I got distracted by the other patches. The bug is still
there, I believe the patch shared by Alvaro in [1] is the right way to
deal with it. I'll take care of that today/tomorrow.
[1]
https://www.postgresql.org/message-id/202401091043.e3nrqiad6gb7@alvherre.pgsql
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tomas.vondra@enterprisedb.com, michael@paquier.xyz, alvherre@alvh.no-ip.org, exclusion@gmail.com, soumyadeep2007@gmail.com, boekewurm+postgres@gmail.com, ashwinstar@gmail.com
Subject: Re: brininsert optimization opportunity
In-Reply-To: <14e52b46-a802-4035-b33a-627968e14375@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox