pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Jan Przemysław Wójcik <jan.przemyslaw.wojcik@gmail.com>
To: pgsql-bugs@postgresql.org
Subject: Re: Fwd: pg_trgm word_similarity inconsistencies or bug
Date: Tue, 7 Nov 2017 05:51:35 -0700 (MST)
Message-ID: <1510059095836-0.post@n3.nabble.com> (raw)
In-Reply-To: <CAPpHfdsDtQJ+pYfapH7GMt9n4RLByKMzHEBWcPL99C_g+rkUKQ@mail.gmail.com>
References: <CY4PR17MB13207ED8310F847CF117EED0D85A0@CY4PR17MB1320.namprd17.prod.outlook.com>
	<20171028082225.GA2157@arthur.localdomain>
	<CAPpHfdtz4a9dTxp-Fpem8uBdSBuOQV_i2xuFyL1tG6zM6nAkpg@mail.gmail.com>
	<CA+YsLFp9scUNjjfYJC=84V9o-ZB66GWPq3e_Jveqs1bNejA4qA@mail.gmail.com>
	<CAPpHfdsDtQJ+pYfapH7GMt9n4RLByKMzHEBWcPL99C_g+rkUKQ@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-bugs>

Hi,

my statement about the function usefulness was probably too categorical,
though I had in mind the current name of the function. 

I'm afraid that creating a function that implements quite different
algorithms depending on a global parameter seems very hacky and would lead
to misunderstandings. I do understand the need of backward compatibility,
but I'd opt for the lesser evil. Perhaps a good idea would be to change the
name to 'substring_similarity()' and introduce the new function
'word_similarity()' later, for example in the next major version release.

------
Jan Przemysław Wójcik 



--
Sent from: http://www.postgresql-archive.org/PostgreSQL-bugs-f2117394.html


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs



view thread (28+ messages)  latest in thread

Message-ID: <1510059095836-0.post@n3.nabble.com>
Permalink:  ../1510059095836-0.post@n3.nabble.com/
Also on:    postgresql.org/message-id/1510059095836-0.post@n3.nabble.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: jan.przemyslaw.wojcik@gmail.com, pgsql-bugs@postgresql.org
  Subject: Re: Fwd: pg_trgm word_similarity inconsistencies or bug
  In-Reply-To: <1510059095836-0.post@n3.nabble.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox