From: Andrey Klychkov <aaklychkov@mail.ru>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Victor Yegorov <vyegorov@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re[2]: Alter index rename concurrently to
Date: Mon, 08 Oct 2018 10:48:46 +0300
Message-ID: <1538984926.855959325@f375.i.mail.ru> (raw)
In-Reply-To: <aa4b16af-5cca-ded6-f5fa-1a0dadcf5906@2ndquadrant.com>
References: <1531767486.432607658@f357.i.mail.ru>
<1538567488.953452852@f403.i.mail.ru>
<aa4b16af-5cca-ded6-f5fa-1a0dadcf5906@2ndquadrant.com>
> Attached is an updated patch.
That's OK now, the patch applying is without any errors.
I have no more remarks.
>Пятница, 5 октября 2018, 13:04 +03:00 от Peter Eisentraut <peter.eisentraut@2ndquadrant.com>:
>
>On 03/10/2018 13:51, Andrey Klychkov wrote:
>> 1. Patch was applied without any errors except a part related to
>> documentation:
>> error: patch failed: doc/src/sgml/ref/alter_index.sgml:50
>> error: doc/src/sgml/ref/alter_index.sgml: patch does not apply
>
>Attached is an updated patch.
>
>> 2. The code has been compiled successfully, configured by:
>> # ./configure CFLAGS="-O0" --enable-debug --enable-cassert
>> --enable-depend --without-zlib
>
>Not sure why you use -O0 here. It's not a good idea for development,
>because it might miss interesting warnings.
>
>> 7. Code style:
>> +RenameRelationInternal(Oid myrelid, const char *newrelname, bool
>> is_internal, bool is_index)
>> This line is longer than 80 chars.
>
>pgindent leaves this line alone.
>
>--
>Peter Eisentraut http://www.2ndQuadrant.com/
>PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Regards,
Andrey Klychkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: aaklychkov@mail.ru, peter.eisentraut@2ndquadrant.com, robertmhaas@gmail.com, vyegorov@gmail.com
Subject: Re: Re[2]: Alter index rename concurrently to
In-Reply-To: <1538984926.855959325@f375.i.mail.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox