pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Cleaning up historical portability baggage
Date: Sat, 06 Aug 2022 20:25:13 -0400
Message-ID: <154532.1659831913@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+hUKG+yjRyxt-WHkV9QXG=1j_QQu5-7+Go24PC-prVN9tFvxA@mail.gmail.com>
References: <CA+hUKG+MOzmDkr27ceG8+uwgFxbJUUv699V3VP3DCioQigrf7A@mail.gmail.com>
	<1249825.1658622186@sss.pgh.pa.us>
	<CA+hUKGLryBW4fNYoXzMG9y1e0H-QOTdSiTG46xCr1DNuuPwbeg@mail.gmail.com>
	<CA+hUKGJMcwbzRyfTocfxbPBUhERqKE42d-L22jQ+vpB7an-NjQ@mail.gmail.com>
	<20220804013546.h65najrzig764jar@awork3.anarazel.de>
	<3295936.1659577924@sss.pgh.pa.us>
	<20220804023010.24snkyq3hser5pxq@awork3.anarazel.de>
	<CA+hUKGLjffiULiVs5K4mi8FO5dgfngjKx5n9vZdDzQB9hzfurw@mail.gmail.com>
	<CA+hUKGJJxtpG12XFu6XJRxo+1ZmTrnYwY9_e8FgrVS7K9ar5Mg@mail.gmail.com>
	<20220805210823.u546w4p4wzfany7p@awork3.anarazel.de>
	<20220806000311.ywx65iuchvj4qn2k@awork3.anarazel.de>
	<148623.1659827307@sss.pgh.pa.us>
	<CA+hUKGKwRpvGfcfq2qNVAQS2Wg1B9eA9QRhAmVSyJt1zsCN2sQ@mail.gmail.com>
	<149696.1659828174@sss.pgh.pa.us>
	<CA+hUKG+yjRyxt-WHkV9QXG=1j_QQu5-7+Go24PC-prVN9tFvxA@mail.gmail.com>

Thomas Munro <thomas.munro@gmail.com> writes:
> On Sun, Aug 7, 2022 at 11:22 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Thomas Munro <thomas.munro@gmail.com> writes:
>>> I also wonder if half the stuff in win32gettimeofday.c can be deleted.

> This looks good on CI (well I haven't waited for it to finish yet, but
> MSVC compiles it without warning and we're most of the way through the
> tests...).

Looks plausible from here.  A couple other thoughts:

* While you're at it you could fix the "MinW" typo just above
the extern for gettimeofday.

* I'm half tempted to add something like this to gettimeofday:

	/*
	 * POSIX declines to define what tzp points to, saying
	 * "If tzp is not a null pointer, the behavior is unspecified".
	 * Let's take this opportunity to verify that noplace in
	 * Postgres tries to use any unportable behavior.
	 */
	Assert(tzp == NULL);

			regards, tom lane





view thread (108+ messages)  latest in thread

Message-ID: <154532.1659831913@sss.pgh.pa.us>
Permalink:  ../154532.1659831913@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/154532.1659831913@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, thomas.munro@gmail.com, andres@anarazel.de, andrew@dunslane.net, robertmhaas@gmail.com
  Subject: Re: Cleaning up historical portability baggage
  In-Reply-To: <154532.1659831913@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox