From: Georgios Kokolatos <gkokolatos@pm.me>
To: pgsql-hackers@lists.postgresql.org
Cc: Fabien Coelho <postgresql.org@coelho.net>
Subject: Re: CPU costs of random_zipfian in pgbench
Date: Wed, 13 Mar 2019 08:55:10 +0000
Message-ID: <155246731010.16480.15850913449923768119.pgcf@coridan.postgresql.org> (raw)
In-Reply-To: <alpine.DEB.2.21.1902221716430.4182@lancre>
References: <b5e172e9-ad22-48a3-86a3-589afa20e8f7@2ndquadrant.com>
<alpine.DEB.2.21.1902221716430.4182@lancre>
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation: not tested
For whatever it is worth, the patch looks good to me.
A minor nitpick would be to use a verb in the part:
`cost when the parameter in (0, 1)`
maybe:
`cost when the parameter's value is in (0, 1)` or similar.
Apart from that, I would suggest it that the patch could be moved to
Waiting for Author state.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: gkokolatos@pm.me, pgsql-hackers@lists.postgresql.org, postgresql.org@coelho.net
Subject: Re: CPU costs of random_zipfian in pgbench
In-Reply-To: <155246731010.16480.15850913449923768119.pgcf@coridan.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox