From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Sergei Kornilov <sk@zsrv.org>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: Continue work on changes to recovery.conf API
Date: Fri, 28 Sep 2018 16:36:35 -0400
Message-ID: <1563.1538166995@sss.pgh.pa.us> (raw)
In-Reply-To: <22e02b05-cd56-6a6b-962d-6d35995827a5@2ndquadrant.com>
References: <607741529606767@web3g.yandex.ru>
<594281529606887@web2j.yandex.ru>
<3595211530445522@web17o.yandex.ru>
<64b6e400-74fa-3b30-5bcf-4d6a1facbf27@2ndquadrant.com>
<1312381535557435@iva1-a2ffb02749cf.qloud-c.yandex.net>
<22e02b05-cd56-6a6b-962d-6d35995827a5@2ndquadrant.com>
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> I think this was the major point of contention. I reread the old
> thread, and it's still not clear why we need to change this. _type and
> _value look like an EAV system to me. GUC variables should be
> verifiable independent of another variable.
No, they MUST be independently verifiable. The interactions between
the check_xxx functions in this patch are utterly unsafe. We've
learned that lesson before.
> I propose to move this patch forward, keep the settings as they are. It
> can be another patch to rename or reshuffle them.
Please do not commit this in this state.
> I wonder if that would cause any problems. The settings in
> postgresql.auto.conf are normally not PGC_POSTMASTER, otherwise you
> couldn't use ALTER SYSTEM to put them there. Maybe it's OK.
Actually, that works fine. You do have to restart the postmaster
to make them take effect, but it's the same as if you edited the
main config file by hand.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, sk@zsrv.org
Subject: Re: Continue work on changes to recovery.conf API
In-Reply-To: <1563.1538166995@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox