From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Kevin Grittner <Kevin.Grittner@wicourts.gov>
Cc: Dan Ports <drkp@csail.mit.edu>
Cc: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
Cc: pgsql-hackers@postgresql.org
Subject: Re: SSI bug?
Date: Fri, 25 Mar 2011 16:06:30 -0400
Message-ID: <15645.1301083590@sss.pgh.pa.us> (raw)
In-Reply-To: <AANLkTimgy7xgS0zdC0LiU=5zgsSGwKGTaPppeza7WAQb@mail.gmail.com>
References: <20110221234236.4635E19D574@mail.netbsd.org>
<20110318022622.196E519CFCA@mail.netbsd.org>
<4D835508020000250003BAD2@gw.wicourts.gov>
<20110318181832.GB72629@csail.mit.edu>
<4D837F6F020000250003BAF6@gw.wicourts.gov>
<4D838EFC020000250003BB12@gw.wicourts.gov>
<AANLkTimgy7xgS0zdC0LiU=5zgsSGwKGTaPppeza7WAQb@mail.gmail.com>
Robert Haas <robertmhaas@gmail.com> writes:
> On Fri, Mar 18, 2011 at 5:57 PM, Kevin Grittner
> <Kevin.Grittner@wicourts.gov> wrote:
>>> I'm still looking at whether it's sane to try to issue a warning
>>> when an HTAB exceeds the number of entries declared as its
>>> max_size when it was created.
> I don't think it's too late to commit something like this, but I'm not
> clear on whether we want it.
We do *not* want that.
Up to now, I believe the lockmgr's lock table is the only shared hash
table that is expected to grow past the declared size; that can happen
anytime a session exceeds max_locks_per_transaction, which we consider
to be only a soft limit. I don't know whether SSI has introduced any
other hash tables that behave similarly. (If it has, we might want to
rethink the amount of "slop" space we leave in shmem...)
There might perhaps be some value in adding a warning like this if it
were enabled per-table (and not enabled by default). But I'd want to
see a specific reason for it, not just "let's see if we can scare users
with a WARNING appearing out of nowhere".
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, Kevin.Grittner@wicourts.gov, drkp@csail.mit.edu, yamt@mwd.biglobe.ne.jp
Subject: Re: SSI bug?
In-Reply-To: <15645.1301083590@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox