pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: legrand legrand <legrand_legrand@hotmail.com>
To: pgsql-hackers@postgresql.org
Subject: Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?
Date: Mon, 5 Aug 2019 10:30:29 -0700 (MST)
Message-ID: <1565026229657-0.post@n3.nabble.com> (raw)
In-Reply-To: <20190805.162824.123166397.horikyota.ntt@gmail.com>
References: <CAOBaU_YEgEiTuQr8O32TqxdoA+mM=owXKe2P1eKM_5XssR1_FQ@mail.gmail.com>
	<20190731215909.xsygisccnirdld3f@alap3.anarazel.de>
	<CAOBaU_bYGuoN8d3WXQ5HufXfkxuL3M=YCWHa33rRRR-fqLFefA@mail.gmail.com>
	<CA+TgmoYyFN3FuiC+E0Ug4ceXmfUYKpmqx6xZdLZq-F9ZJoZutg@mail.gmail.com>
	<20190801183632.7byx3knosxas4ih3@alap3.anarazel.de>
	<CAOBaU_bY3Fx+L_HL4x9pK1+9z8rDt49q=twcvrNi-fxpBdnJgg@mail.gmail.com>
	<20190801210514.qdiam2oazua6otkk@alap3.anarazel.de>
	<CAOBaU_aPixr3sj8Ov7o4eToOdA0f68ZV+Z4drn2LHn4QJTj8Tg@mail.gmail.com>
	<1564902241482-0.post@n3.nabble.com>
	<20190805.162824.123166397.horikyota.ntt@gmail.com>

Kyotaro Horiguchi-4 wrote
> At Sun, 4 Aug 2019 00:04:01 -0700 (MST), legrand legrand &lt;

> legrand_legrand@

> &gt; wrote in <

> 1564902241482-0.post@.nabble

>>
>> >  However having the nested queryid in 
>> > pg_stat_activity would be convenient to track
>> > what is a long stored functions currently doing.
>> 
>> +1
>> 
>> And  this could permit to get wait event sampling per queryid when
>> pg_stat_statements.track = all
> 
> I'm strongly on this side emotionally, but also I'm on Tom and
> Andres's side that exposing querid that way is not the right
> thing.
> 
> Doing that means we don't need exact correspondence between
> top-level query and queryId (in nested or multistatement queries)
> in this patch.  pg_stat_statements will allow us to do the same
> thing by having additional uint64[MaxBackends] array in
> pgssSharedState, instead of expanding PgBackendStatus array in
> core by the same size.
> 
> regards.
> 
> -- 
> Kyotaro Horiguchi
> NTT Open Source Software Center

Hi Kyotaro,
Thank you for this answer.
What you propose here is already available 
Inside pg_stat_sql_plans extension (a derivative from 
Pg_stat_statements and pg_store_plans)
And I’m used to this queryid behavior with top Level
Queries...
My emotion was high but I will accept it !
Regards
PAscal




--
Sent from: https://www.postgresql-archive.org/PostgreSQL-hackers-f1928748.html





view thread (222+ messages)  latest in thread

Message-ID: <1565026229657-0.post@n3.nabble.com>
Permalink:  ../1565026229657-0.post@n3.nabble.com/
Also on:    postgresql.org/message-id/1565026229657-0.post@n3.nabble.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: legrand_legrand@hotmail.com
  Subject: Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?
  In-Reply-To: <1565026229657-0.post@n3.nabble.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox