pg.ddx.io pgsql-hackers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Stephen Frost <sfrost@snowman.net>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Christoph Berg <myon@debian.org>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: compute_query_id and pg_stat_statements
Date: Thu, 13 May 2021 14:29:09 -0400
Message-ID: <1579535.1620930549@sss.pgh.pa.us> (raw)
In-Reply-To: <20210513180706.GG20766@tamriel.snowman.net>
References: <20210513005236.aj7n6b76yjsxythc@nol>
<20210513011325.GA11075@momjian.us>
<20210513015700.fp33q5rfvwl2ahfx@nol>
<20210513030652.GB11075@momjian.us>
<20210513031613.j47baglf6xl3mgbs@nol>
<20210513033332.GF11075@momjian.us>
<20210513040342.fouh7ryglrfgxglu@nol>
<20210513144143.GG11075@momjian.us>
<YJ1kYeKvYBk0cxti@msg.df7cb.de>
<20210513175947.GP11075@momjian.us>
<20210513180706.GG20766@tamriel.snowman.net>
Stephen Frost <sfrost@snowman.net> writes:
> There's a ridiculously simple option here which is: drop the idea that
> we support an extension redefining the query id and then just make it
> on/off with the default to be 'on'.
I do not think that defaulting it to 'on' is acceptable unless you can
show that the added overhead is negligible. IIUC the measurements that
have been done show the opposite.
Maybe we should revert this thing pending somebody doing the work to
make a version of queryid labeling that actually is negligibly cheap.
It certainly seems like that could be done; one more traversal of the
parse tree can't be that expensive in itself. I suspect that the
performance problem is with the particular hashing mechanism that
was used, which looks mighty ad-hoc anyway.
regards, tom lane
view thread (158+ messages) latest in thread
Message-ID: <1579535.1620930549@sss.pgh.pa.us> Permalink: ../1579535.1620930549@sss.pgh.pa.us/ Also on: postgresql.org/message-id/1579535.1620930549@sss.pgh.pa.us ·
reply
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Reply to all the recipients using the --to and --cc options: reply via email To: pgsql-hackers@postgresql.org Cc: tgl@sss.pgh.pa.us, sfrost@snowman.net, bruce@momjian.us, myon@debian.org, rjuju123@gmail.com, pavel.stehule@gmail.com, horikyota.ntt@gmail.com, magnus@hagander.net, masao.fujii@oss.nttdata.com, michael@paquier.xyz, andres@anarazel.de, alvherre@alvh.no-ip.org, peter.eisentraut@enterprisedb.com, pgsql-hackers@lists.postgresql.org Subject: Re: compute_query_id and pg_stat_statements In-Reply-To: <1579535.1620930549@sss.pgh.pa.us> * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox