From: Jürgen Purtz <juergen@purtz.de>
To: pgsql-hackers@lists.postgresql.org
Cc: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Subject: Re: [PATCH] Add section headings to index types doc
Date: Mon, 10 Aug 2020 12:52:17 +0000
Message-ID: <159706393772.790.11301900224459454375.pgcf@coridan.postgresql.org> (raw)
In-Reply-To: <2268714.1596457003@sss.pgh.pa.us>
References: <877dukhvzg.fsf@wibble.ilmari.org>
<2268714.1596457003@sss.pgh.pa.us>
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation: tested, passed
a) I'm wondering if we should apply one more change to this page. The line-by-line listing of operators occupies much space. What do you think about an inline list (in a separate line) of the operators?
old source:
<simplelist>
<member><literal><</literal></member>
<member><literal><=</literal></member>
<member><literal>=</literal></member>
<member><literal>>=</literal></member>
<member><literal>></literal></member>
</simplelist>
new source:
<synopsis>< <= = >= ></synopsis>
It looks nice in HTML as well as in PDF.
b) I'm in favor of the indentation of all affected lines as it is done in the patch.
The new status of this patch is: Waiting on Author
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: juergen@purtz.de, pgsql-hackers@lists.postgresql.org, ilmari@ilmari.org
Subject: Re: [PATCH] Add section headings to index types doc
In-Reply-To: <159706393772.790.11301900224459454375.pgcf@coridan.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox