public inbox for [email protected]
help / color / mirror / Atom feedFrom: Andrew Dunstan <[email protected]>
To: Jeevan Chalke <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: More new SQL/JSON item methods
Date: Wed, 17 Jan 2024 11:53:23 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAM2+6=WyoinYoiuf3msxqH-hsPBoUz33MmrCpD_4Ceo6Nq1qOg@mail.gmail.com>
References: <CAM2+6=XjTyqrrqHAOj80r0wVQxJSxc0iyib9bPC55uFO9VKatg@mail.gmail.com>
<[email protected]>
<CAM2+6=XTW1COd+56ekjP=CUceZyrgyrcBge_z0ZRkCgVwcGHQg@mail.gmail.com>
<[email protected]>
<CAM2+6=UCSp74devvHYpMx5NvpyWbCO3gYvgpEYHtNYqF2j6Z9Q@mail.gmail.com>
<[email protected]>
<CAM2+6=UrDfcsz0xn+oUmomOnPYazuP8dAM_Wrx5YMsWxXjWyKA@mail.gmail.com>
<[email protected]>
<CAM2+6=UMCtXVSk1NmGHzsYYY6xGdnaMMKxVaKUtG7o0jkiuyQg@mail.gmail.com>
<[email protected]>
<[email protected]>
<CAM2+6=XPHNJnGypXy2C_5TUWgCxCktz1GrwuzsSZSqb_R+pMXQ@mail.gmail.com>
<CAM2+6=WYbL4gxpmEJcN5BvLYuMZUpruLQRZxFeKTBNNpksgN=g@mail.gmail.com>
<[email protected]>
<CAM2+6=WyoinYoiuf3msxqH-hsPBoUz33MmrCpD_4Ceo6Nq1qOg@mail.gmail.com>
On 2024-01-17 We 04:03, Jeevan Chalke wrote:
>
>
> On Mon, Jan 15, 2024 at 7:41 PM Peter Eisentraut
> <[email protected]> wrote:
>
>
> Overall, I think it would be better if you combined all three of
> these
> patches into one. Right now, you have arranged these as incremental
> features, and as a result of that, the additions to the
> JsonPathItemType
> enum and the grammar keywords etc. are ordered in the way you
> worked on
> these features, I guess. It would be good to maintain a bit of
> sanity
> to put all of this together and order all the enums and everything
> else
> for example in the order they are in the sql_features.txt file
> (which is
> alphabetical, I suppose). At this point I suspect we'll end up
> committing this whole feature set together anyway, so we might as
> well
> organize it that way.
>
>
> OK.
> I will merge them all into one and will try to keep them in the order
> specified in sql_features.txt.
> However, for documentation, it makes more sense to keep them in
> logical order than the alphabetical one. What are your views on this?
>
I agree that we should order the documentation logically. Users don't
care how we organize the code etc, but they do care about docs have
sensible structure.
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
view thread (27+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: More new SQL/JSON item methods
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox