pg.ddx.io pgsql-hackers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
Putting kerberos/ldap logs somewhere useful 2+ messages / 2 participants [nested] [flat]
Commits from this thread: 2019-08-06 4ecd05cb77 514e7e911f f1c23b00b9 Save Kerberos and LDAP daemon logs where the buildfarm can find them.
* Putting kerberos/ldap logs somewhere useful @ 2019-08-05 23:26 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 1 reply; 2+ messages in thread From: Tom Lane @ 2019-08-05 23:26 UTC (permalink / raw) To: pgsql-hackers@lists.postgresql.org I got frustrated just now because this: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2019-08-05%2021%3A18%3A23 is essentially undebuggable, thanks to the buildfarm's failure to capture any error output from slapd. That's not the buildfarm script's fault: it's willing to capture everything placed in the agreed-on log directory. But the TAP test script randomly places the daemon's log file somewhere else, one level up. The kerberos test script has the same problem. Hence, I propose the attached. This just moves the actual log files ... we could possibly move the daemons' .conf files as well, but I think they're probably not variable enough to be interesting. regards, tom lane Attachments:^ permalink raw reply [nested|flat] 2+ messages in threadput-krb-and-ldap-logs-somewhere-useful.patch (text/x-diff, 1.3K) download
diff --git a/src/test/kerberos/t/001_auth.pl b/src/test/kerberos/t/001_auth.pl index 34845a7..e3eb052 100644 --- a/src/test/kerberos/t/001_auth.pl +++ b/src/test/kerberos/t/001_auth.pl @@ -67,8 +67,8 @@ my $realm = 'EXAMPLE.COM'; my $krb5_conf = "${TestLib::tmp_check}/krb5.conf"; my $kdc_conf = "${TestLib::tmp_check}/kdc.conf"; -my $krb5_log = "${TestLib::tmp_check}/krb5libs.log"; -my $kdc_log = "${TestLib::tmp_check}/krb5kdc.log"; +my $krb5_log = "${TestLib::log_path}/krb5libs.log"; +my $kdc_log = "${TestLib::log_path}/krb5kdc.log"; my $kdc_port = get_free_port(); my $kdc_datadir = "${TestLib::tmp_check}/krb5kdc"; my $kdc_pidfile = "${TestLib::tmp_check}/krb5kdc.pid"; diff --git a/src/test/ldap/t/001_auth.pl b/src/test/ldap/t/001_auth.pl index 47bc090..5efb87a 100644 --- a/src/test/ldap/t/001_auth.pl +++ b/src/test/ldap/t/001_auth.pl @@ -52,7 +52,7 @@ my $ldap_datadir = "${TestLib::tmp_check}/openldap-data"; my $slapd_certs = "${TestLib::tmp_check}/slapd-certs"; my $slapd_conf = "${TestLib::tmp_check}/slapd.conf"; my $slapd_pidfile = "${TestLib::tmp_check}/slapd.pid"; -my $slapd_logfile = "${TestLib::tmp_check}/slapd.log"; +my $slapd_logfile = "${TestLib::log_path}/slapd.log"; my $ldap_conf = "${TestLib::tmp_check}/ldap.conf"; my $ldap_server = 'localhost'; my $ldap_port = get_free_port();
* Re: Putting kerberos/ldap logs somewhere useful @ 2019-08-06 05:17 Michael Paquier <michael@paquier.xyz> parent: Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Michael Paquier @ 2019-08-06 05:17 UTC (permalink / raw) To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-hackers@lists.postgresql.org On Mon, Aug 05, 2019 at 07:26:45PM -0400, Tom Lane wrote: > Hence, I propose the attached. This just moves the actual log > files ... +1 for this. The patch looks good. > we could possibly move the daemons' .conf files as well, > but I think they're probably not variable enough to be interesting. Not sure that it is actually necessary. If that proves to be needed, this could always be done later on. -- Michael Attachments: signature.asc (application/pgp-signature, 832B) download ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2019-08-06 05:17 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2019-08-05 23:26 Putting kerberos/ldap logs somewhere useful Tom Lane <tgl@sss.pgh.pa.us> 2019-08-06 05:17 ` Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox